Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Enable profiling recompilation #5350

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jun 26, 2020

This commit enables profiling recompilation on AArch64.

Signed-off-by: KONNO Kazuhiro [email protected]

@knn-k knn-k requested review from 0xdaryl and mstoodle as code owners June 26, 2020 09:43
@knn-k knn-k marked this pull request as draft June 26, 2020 09:43
@knn-k
Copy link
Contributor Author

knn-k commented Jun 26, 2020

@genie-omr build aarch64

This commit enables profiling recompilation on AArch64.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k knn-k force-pushed the aarch64recomp2 branch from 60f0f0e to 5252713 Compare July 8, 2020 01:13
@0xdaryl
Copy link
Contributor

0xdaryl commented Dec 3, 2020

Sorry, I don't remember the fundamental reason preventing profiling from being enabled. Is it a bug, or is the work to support profiling on AArch64 just not completed yet?

@knn-k knn-k marked this pull request as ready for review December 3, 2020 23:13
@knn-k knn-k changed the title WIP: AArch64: Enable profiling recompilation AArch64: Enable profiling recompilation Dec 3, 2020
@knn-k
Copy link
Contributor Author

knn-k commented Dec 3, 2020

Profiling recompilation for AArch64 has been working with my local build for a couple of months.
I just forgot to change the status of this PR from draft to ready.

@0xdaryl 0xdaryl self-assigned this Dec 7, 2020
@0xdaryl 0xdaryl merged commit 32a0154 into eclipse-omr:master Dec 7, 2020
@knn-k knn-k deleted the aarch64recomp2 branch December 7, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants