Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying function calls of TR_S390Peephole in OMR #3942

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

wbh123456
Copy link
Contributor

@wbh123456 wbh123456 commented Jun 3, 2019

Simplifying function calls of TR_S390Peephole, TR_S390PostRAPeephole and
TR_S390RreRAPeephole. They now require TR::Compilation* comp as the only 1 argument. This will close #1855 as there is no more function that passes both cg and comp at the same time.

Closes: #1855
Signed-off-by: Bohao(Aaron) Wang [email protected]

Simplifying function calls of TR_S390Peephole, TR_S390PostRAPeephole and
TR_S390RreRAPeephole by not passing paramter cg.

Issue:eclipse-omr#1855
Signed-off-by: Bohao(Aaron) Wang <[email protected]>
@wbh123456 wbh123456 requested a review from fjeremic as a code owner June 3, 2019 19:27
@fjeremic fjeremic self-assigned this Jun 3, 2019
@wbh123456 wbh123456 changed the title WIP: Simplifying function calls of TR_S390Peephole in OMR Simplifying function calls of TR_S390Peephole in OMR Jun 4, 2019
@fjeremic
Copy link
Contributor

fjeremic commented Jun 4, 2019

@genie-omr build zlinux

@fjeremic fjeremic merged commit 26088c9 into eclipse-omr:master Jun 4, 2019
@wbh123456 wbh123456 deleted the peephole branch June 4, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid passing both CodeGenerator and Compilation objects in an API
2 participants