Relocate OMR::SupportsBigDecimalLongLookasideVersioning to OpenJ9 #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OMR::CodeGenerator class defines functionsgetSupportsBigDecimalLongLookasideVersioning and setSupportsBigDecimalLongLookasideVersioning that are not used in OMR. They only have relevance in OpenJ9 and should be relocated to the J9::CodeGenerator class there. Issue: eclipse-omr#1882 Signed-off-by: Bohao(Aaron) Wang <[email protected]>
wbh123456
force-pushed
the
MoveGetSupportsFunctions
branch
from
0c51805 to
cb04d3b
Compare
wbh123456
changed the title
|
@genie-omr build all |
|
@vijaysun-omr ping |
|
Wondering if we still even need this at OpenJ9 now that we use OpenJDK's versions of BigDecimal/BigInteger. Food for thought. |
|
If it is deprecated then removal is a good idea, but only if truly deprecated. |
|
We could probably just merge this as this patch removes the filed anyways. Then we could open a new PR to delete the field from OpenJ9 if it is truly deprecated. |
|
@vijaysun-omr @0xdaryl Do we merge this? |
|
@vijaysun-omr ping? |
vijaysun-omr
approved these changes
Jun 4, 2019
|
Looks very safe and checks have passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OMR::CodeGeneratorclass definesfunctionsgetSupportsBigDecimalLongLookasideVersioningandsetSupportsBigDecimalLongLookasideVersioningthat are not used in OMR.They only have relevance in OpenJ9 and should be relocated to the
J9::CodeGeneratorclass there.Closes: #1882
Signed-off-by: Bohao(Aaron) Wang [email protected]