Misc. Power linkage cleanup #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xdaryl
commented
May 20, 2019
0xdaryl
commented
- Remove and fold calculateParameterRegisterOffset from Linkage
- Remove and fold calculateActualParameterOffset from Linkage
- Fold and simplify code in Power linkage saveArguments
- Unify float/double handling in Power linkage
|
@genie-omr build plinux This is a Power-specific change. A full genie build is not required. |
ymanton
approved these changes
May 21, 2019
The Power Linkage defines this function which is entirely short-circuited on all implementations. Remove it and fold code around it. Signed-off-by: Daryl Maier <[email protected]>
The Power Linkage defines this function which is entirely short-circuited on all implementations. Remove it and fold code around it. Signed-off-by: Daryl Maier <[email protected]>
* fold paths guarded with `all_saved` as it is only false * simplify some instruction generation paths Signed-off-by: Daryl Maier <[email protected]>
Unify handling of float and doubles in loadUpArguments/flushArguments. Signed-off-by: Daryl Maier <[email protected]>
|
@genie-omr build plinux |
gita-omr
approved these changes
May 21, 2019
|
Reviews and testing have completed. Would another committer (e.g., @Leonardo2718 @fjeremic ) mind merging this please? |
fjeremic
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.