Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable OMR_THR_YIELD_ALG on MacOS #3283

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Disable OMR_THR_YIELD_ALG on MacOS #3283

merged 1 commit into from
Dec 10, 2018

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Dec 4, 2018

OMR_THR_YIELD_ALG should only be used with Completely Fair Scheduler
(CFS). CFS is only available on Linux.

MacOS schedulers can be classified as multilevel feedback queue
schedulers. MacOS doesn't use CFS. Thus, disabling OMR_THR_YIELD_ALG on
MacOS.

Signed-off-by: Babneet Singh [email protected]

@babsingh
Copy link
Contributor Author

babsingh commented Dec 4, 2018

fyi - @charliegracie @DanHeidinga

@babsingh
Copy link
Contributor Author

babsingh commented Dec 4, 2018

Related to eclipse-openj9/openj9#36

@babsingh
Disable OMR_THR_YIELD_ALG on MacOS
27df295 
OMR_THR_YIELD_ALG should only be used with Completely Fair Scheduler
(CFS). CFS is only available on Linux.

MacOS schedulers can be classified as multilevel feedback queue
schedulers. MacOS doesn't use CFS. Thus, disabling OMR_THR_YIELD_ALG on
MacOS.

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh force-pushed the disable_cfs_support_osx branch from 48c9a75 to 27df295 Compare December 4, 2018 21:07
@babsingh babsingh requested a review from youngar as a code owner December 4, 2018 21:07
@babsingh babsingh mentioned this pull request Dec 4, 2018
Closed
@charliegracie
Copy link
Contributor

The OMR_THR_YIELD_ALG flag is now being turned off for OS X in the auto-tools build system. The auto-tools build system is not used for OS X testing in OMR. When looking into this change I noticed that ALL linux platforms are enabling this option in the auto-tools build system. Again the default OMR CI testing uses CMake on all Linux platforms so technically OMR is not testing this feature at all. Should this be enabled by default on all Linux platforms?

@babsingh
Copy link
Contributor Author

babsingh commented Dec 6, 2018

Should OMR_THR_YIELD_ALG be enabled by default on all Linux platforms?

OMR_THR_YIELD_ALG introduces optimizations for Completely Fair Scheduler
(CFS). Since Linux uses CFS, OMR_THR_YIELD_ALG should be enabled by default on all Linux platforms.

@charliegracie charliegracie self-assigned this Dec 10, 2018
@charliegracie
Copy link
Contributor

No further CI testing required since only the OS X auto-tools build system was modified and there is not CI testing that uses it.

@charliegracie charliegracie merged commit 0726760 into eclipse-omr:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliegracie charliegracie Awaiting requested review from charliegracie

@youngar youngar Awaiting requested review from youngar

Assignees

@charliegracie charliegracie

Labels
build / configure comp:glue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babsingh @charliegracie @Leonardo2718