Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP2 when building libwebsockets for docker images. #2255

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

tparker-usgs
Copy link
Contributor

@tparker-usgs tparker-usgs commented Jul 15, 2021

As reported in #1211, Firefox cannot connect over websocekts with TLS when using HTTP2. Without HTTP2 support in libwebsockets the connections fallback to HTTP and are able to complete.

This work around has been successfully used by multiple commenters and tests well. This pull requests implements the work around when building Docker images.

Signed-off-by: Tom Parker [email protected]

Copy link
Contributor

@ralight ralight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you very much. I'll see about getting it applied to the images straight away.

@ralight ralight merged commit 17bbca2 into eclipse-mosquitto:master Jul 28, 2021
@ralight
Copy link
Contributor

ralight commented Jul 28, 2021

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants