Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to exclude property from validation #95

Closed
angelozerr opened this issue Oct 28, 2020 · 5 comments · Fixed by #102
Closed

Contribute to exclude property from validation #95

angelozerr opened this issue Oct 28, 2020 · 5 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request validation
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Oct 28, 2020

See the issue redhat-developer/vscode-microprofile#22

Today user can exclude properties to ignore validation with settings. This issue gives the capability to contribute for excluded properties with Java SPI.

//cc @apupier

@angelozerr angelozerr added enhancement New feature or request validation labels Oct 28, 2020
@angelozerr angelozerr self-assigned this Oct 28, 2020
@angelozerr angelozerr added this to the 0.2.0 milestone Oct 28, 2020
@angelozerr angelozerr changed the title Contribute to excluded property with Java SPI Contribute to exclude property from validation with Java SPI Oct 28, 2020
@angelozerr
Copy link
Contributor Author

Here my idea how to contribute to exclude validation:

  • create a file META-INF/lsp4mp/settings.json
  • write the settings.json file like this:
{
	"validation": {
		"unknown": {
			"excluded": [
				"camel.*"
			]
		}
	}
}

The idea is to provide the capability to contribute another settings (not the whole) from extension.

@fbricon what do you think about this idea?

@fbricon
Copy link
Contributor

fbricon commented Nov 3, 2020

interesting idea, but how do you handle conflicts between different colliding settings from different jars. Would the list of supported settings be restricted?

@angelozerr
Copy link
Contributor Author

interesting idea, but how do you handle conflicts between different colliding settings from different jars.

My idea is to manage for the moment only exclude validation settings. Have you some usecase about conflicts?

Perhaps one extension exclude only camel.* and an another extension exclude only camel.abcd.*. If it that, what can we done?

Would the list of supported settings be restricted?

Yes for the moment I would like to just take validation excluded settings. Enable codelens settings would be ignored for instance.

My initial idea is to follow the same format than user settings by filtering settings (for the moment only validation excludeded will be get)

@fbricon
Copy link
Contributor

fbricon commented Nov 3, 2020

Perhaps one extension exclude only camel.* and an another extension exclude only camel.abcd.*. If it that, what can we done?

I guess both exclusions apply (same as today), meaning camel.* will take precedence anyways

@angelozerr
Copy link
Contributor Author

I guess both exclusions apply (same as today), meaning camel.* will take precedence anyways

Yes exactly, so we don't manage conflicts for this validation settings excluded.

@angelozerr angelozerr changed the title Contribute to exclude property from validation with Java SPI Contribute to exclude property from validation Nov 3, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 3, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 3, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 3, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 3, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 10, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 12, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Nov 16, 2020
angelozerr added a commit that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants