Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LanguageClient.setTrace method to LanguageServer #545

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Move LanguageClient.setTrace method to LanguageServer #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

Fixed issues: <https://github.com/eclipse/lsp4j/milestone/20?closed=1>

Breaking API changes:

* Method `LanguageClient.setTrace` moved to `LanguageServer`, where it should
have been according to the specification

### v0.12.0 (Apr. 2021)

* Restored `org.eclipse.lsp4j.websocket` which will be included along with `org.eclipse.lsp4j.websocket.jakarta`. This will allow use of LSP4J
Expand Down
11 changes: 0 additions & 11 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/services/LanguageClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.eclipse.lsp4j.ProgressParams;
import org.eclipse.lsp4j.PublishDiagnosticsParams;
import org.eclipse.lsp4j.RegistrationParams;
import org.eclipse.lsp4j.SetTraceParams;
import org.eclipse.lsp4j.ShowDocumentParams;
import org.eclipse.lsp4j.ShowDocumentResult;
import org.eclipse.lsp4j.ShowMessageRequestParams;
Expand Down Expand Up @@ -178,16 +177,6 @@ default void logTrace(LogTraceParams params) {
throw new UnsupportedOperationException();
}

/**
* A notification that should be used by the client to modify the trace setting of the server.
*
* Since 3.16.0
*/
@JsonNotification("$/setTrace")
default void setTrace(SetTraceParams params) {
throw new UnsupportedOperationException();
}

/**
* The `workspace/semanticTokens/refresh` request is sent from the server to the client.
* Servers can use it to ask clients to refresh the editors for which this server
Expand Down
12 changes: 11 additions & 1 deletion org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/services/LanguageServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.eclipse.lsp4j.InitializeParams;
import org.eclipse.lsp4j.InitializeResult;
import org.eclipse.lsp4j.InitializedParams;
import org.eclipse.lsp4j.SetTraceParams;
import org.eclipse.lsp4j.WorkDoneProgressCancelParams;
import org.eclipse.lsp4j.jsonrpc.services.JsonDelegate;
import org.eclipse.lsp4j.jsonrpc.services.JsonNotification;
Expand Down Expand Up @@ -95,5 +96,14 @@ default void initialized() {
default void cancelProgress(WorkDoneProgressCancelParams params) {
throw new UnsupportedOperationException();
}


/**
* A notification that should be used by the client to modify the trace setting of the server.
*
* Since 3.16.0
*/
@JsonNotification("$/setTrace")
default void setTrace(SetTraceParams params) {
throw new UnsupportedOperationException();
}
}