-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more versions of gson? #611
Comments
Hi @frankbenoit, that sounds reasonable. Please can you provide a patch? |
https://github.com/eclipse/lsp4j/blob/32ad52691b2fcaef7011ffc6461641f1164dc1f2/gradle/versions.gradle#L19 |
Yes, but this is exactly 1 version. After 2.8.9 they released 2.9.0 |
and were there some breaking changes or do they do sem. versioning? |
The minimum supported Java version changes from 6 to 7. |
Google? semver and no breaking changes? Ha! They can break backward compatibility in a patch release. |
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
we will go with [2.9.0,2.10) for now |
switch to orbit 2022-09 and widen version range for gson. See #611
Currently only exactly gson 2.8.9 is allowed.
Would it be possible to allow a wider range?
if the semantic versioning is valid, even [2.8.9,3.0) should be ok.
This would simplify the coexistence with other bundles that have dependencies to gson.
The text was updated successfully, but these errors were encountered: