Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more versions of gson? #611

Closed
frankbenoit opened this issue May 2, 2022 · 7 comments
Closed

Allow more versions of gson? #611

frankbenoit opened this issue May 2, 2022 · 7 comments
Assignees
Milestone

Comments

@frankbenoit
Copy link

Currently only exactly gson 2.8.9 is allowed.
Would it be possible to allow a wider range?
if the semantic versioning is valid, even [2.8.9,3.0) should be ok.
This would simplify the coexistence with other bundles that have dependencies to gson.

@jonahgraham
Copy link
Contributor

Hi @frankbenoit, that sounds reasonable. Please can you provide a patch?

@cdietrich
Copy link
Contributor

@frankbenoit
Copy link
Author

Yes, but this is exactly 1 version. After 2.8.9 they released 2.9.0

@cdietrich
Copy link
Contributor

and were there some breaking changes or do they do sem. versioning?

@frankbenoit
Copy link
Author

The minimum supported Java version changes from 6 to 7.
https://github.com/google/gson/releases/tag/gson-parent-2.9.0

@nixel2007
Copy link
Contributor

nixel2007 commented May 2, 2022

and were there some breaking changes or do they do sem. versioning?

Google? semver and no breaking changes? Ha! They can break backward compatibility in a patch release.

cdietrich added a commit that referenced this issue Jul 9, 2022
cdietrich added a commit that referenced this issue Jul 9, 2022
cdietrich added a commit that referenced this issue Jul 19, 2022
cdietrich added a commit that referenced this issue Jul 19, 2022
cdietrich added a commit that referenced this issue Jul 19, 2022
@cdietrich cdietrich added this to the v0.15.0 milestone Jul 19, 2022
@cdietrich
Copy link
Contributor

we will go with [2.9.0,2.10) for now

@cdietrich cdietrich self-assigned this Jul 19, 2022
cdietrich added a commit that referenced this issue Jul 20, 2022
switch to orbit 2022-09 and widen version range for gson. See #611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants