Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageClient.setTrace should have been a LanguageServer method #544

Closed
pisv opened this issue Apr 11, 2021 · 0 comments · Fixed by #545
Closed

LanguageClient.setTrace should have been a LanguageServer method #544

pisv opened this issue Apr 11, 2021 · 0 comments · Fixed by #545
Milestone
v0.13.0

Comments

@pisv
Copy link
Contributor

pisv commented Apr 11, 2021

As per the specification, setTrace goes in the same direction as exit and other client-to-server notifications. Thus, it should be a method of LanguageServer rather than LanguageClient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Move LanguageClient.setTrace method to LanguageServer pisv/lsp4j
2 participants
@jonahgraham @pisv