Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Composite support for timestamped data. #1637

Closed
JaroslawLegierski opened this issue Aug 7, 2024 · 3 comments
Closed

Read Composite support for timestamped data. #1637

JaroslawLegierski opened this issue Aug 7, 2024 · 3 comments
Labels
question Any question about leshan

Comments

@JaroslawLegierski
Copy link
Contributor

Question

Would it be possible for Leshan to support timestamps in Read Composite operation? Currently the presence of timestamp in the response causes an exception:

"Unable to decode node [node] : value should not be timestamped"

We would like to support to be able to have 1 timestamp like for Simple (not composite) Read and Observe e.g.

[
    { "n":"3/0/1","v":11234, "bt":1706888656 },
    { "bn":"/6/0/","n":"0","v":-21.0 }, 
    { "n":"1","v":141.0 }, 
    { "n":"5","v":1706888656 }
]

I preparred following: PoC supporting described above feature. However, I don't know if my idea of impelementing this is correct.

@sbernard31
Copy link
Contributor

I looked at this quickly, I think this is the idea.
When you think your code is ready for review, create a PR and let me know.

@JaroslawLegierski
Copy link
Contributor Author

I looked at this quickly, I think this is the idea. When you think your code is ready for review, create a PR and let me know.

PR (#1639) created.

@sbernard31
Copy link
Contributor

#1639 is now integrated in master so I close this issue.

(will be available in 2.0.0-M17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Any question about leshan
Projects
None yet
Development

No branches or pull requests

2 participants