Unregister language server extension on LS shutdown #608
Conversation
...pse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/extensions/XMLExtensionsRegistry.java
Outdated
Show resolved
Hide resolved
...pse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/extensions/XMLExtensionsRegistry.java
Outdated
Show resolved
Hide resolved
AObuchow
force-pushed
the
dipose_extensions_on_shutdown
branch
3 times, most recently
from
c715135
to
39908ec
Compare
...4xml/src/test/java/org/eclipse/lsp4xml/services/extensions/ExtensionRegistryDisposeTest.java
Show resolved
Hide resolved
...4xml/src/test/java/org/eclipse/lsp4xml/services/extensions/ExtensionRegistryDisposeTest.java
Show resolved
Hide resolved
AObuchow
force-pushed
the
dipose_extensions_on_shutdown
branch
from
39908ec
to
912e1d3
Compare
|
Last thing to do, do try/cacth inside unregisterExtension like it's done in registerExtension to be sure to call stop for each extension even if there is an extension which fails. I notice that in https://github.com/angelozerr/lsp4xml/blob/1057f73f1d29c91b0bcb20a1c78ae72e03d8c21a/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/extensions/XMLExtensionsRegistry.java#L90 no try catch is done, please do it. Thanks! |
fix eclipse-lemminx#605 Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow
force-pushed
the
dipose_extensions_on_shutdown
branch
from
912e1d3
to
c4b7450
Compare
Ok, it's done |
|
It's perfect @AObuchow, thanks! |
|
@angelozerr thanks for the review! Now the Maven extension's test should be happy :) |
You are welcome!
Nice :) |
fix #605
Signed-off-by: Andrew Obuchowicz [email protected]