Add lexer error message provider #1716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabounegm
reviewed
Oct 16, 2024
| import type { LexingReport, TokenBuilder } from './token-builder.js'; | ||
|
|
||
| export abstract class AbstractLexerErrorMessageProvider implements ILexerErrorMessageProvider { |
There was a problem hiding this comment.
Wouldn't it be more in line with the rest of the implementation (especially in the parser module) if this was instead:
Suggested change
| export abstract class AbstractLexerErrorMessageProvider implements ILexerErrorMessageProvider { | |
| export class DefaultLexerErrorMessageProvider implements ILexerErrorMessageProvider { |
and then this was the class used in src/default-module.ts instead of using defaultLexerErrorProvider directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue exposed in #1715. Currently, there's no easy way to override the lexer error message provider for chevrotain.
This change adds a service that will be used by the lexer for that.