Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Ignore signal values that are out of the defined range #147

Merged

Conversation

sophokles73
Copy link
Contributor

The message definition database may contain signals for which a
minimum and/or maximum value has been defined. In particular,
j1939 uses "special" out-of-range values to indicate that a signal
is not available (at the moment). These "special" values should not
be published to the Databroker.

The CanReader has been altered to ignore signal values from CAN
messages which do not match the defined min/max values.

@sophokles73 sophokles73 force-pushed the ignore_signal_values_out_of_range branch from 1665879 to 3e796e9 Compare October 23, 2023 15:13
The message definition database may contain signals for which a
minimum and/or maximum value has been defined. In particular,
j1939 uses "special" out-of-range values to indicate that a signal
is not available (at the moment). These "special" values should not
be published to the Databroker.

The CanReader has been altered to ignore signal values from CAN
messages which do not match the defined min/max values.
@sophokles73 sophokles73 force-pushed the ignore_signal_values_out_of_range branch from 3e796e9 to 16d7aa4 Compare October 23, 2023 17:29
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, smoke test performed

@erikbosch erikbosch merged commit 9c88491 into eclipse-kuksa:main Oct 26, 2023
5 checks passed
@erikbosch erikbosch deleted the ignore_signal_values_out_of_range branch October 31, 2024 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants