-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing submodule reference to use new repo #23
Conversation
Hmm, noticed that test fails as
We have said that KUKSA Server shall reach EoL 2024-12-31, but we have not yet said when we should remove KUKSA Server support from kuksa-client. I see some options:
Thoughts @SebastianSchildt ? |
Not sure what the best course of action is, but I thing removing support in python-sdk for val-server could be done immediately, as we still do have released, working versions for val-server out. The only point is, that this library also works with the VISS "dialect" of databroker, but going forward, I don"t think supporting VISS and GRPC in one library makes sense (especially since API differences can not be hidden, and the current "threaded" API, supporting both, is an ugly compromise). So I would not hink it is worthwhile t kepp that ability (as for "VISS", rather make a nice Node.red Flow in incubation, or see whether the COVESA CSDP webclient works) |
So then it seems @SebastianSchildt that there is no problem to start by removing default TLS/Token, then we can as a second step decide if we should remove Websocket support or not |
c7379a3
to
9711e0b
Compare
Updated now but should do some more tests |
I have tested pypi package and docker containers, things seems to work. Work might be required in downstream projects if they in test or documentation rely on that tokens/keys/certificates are available locally and default values exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did some manual checking with latest databroker, seems to work lgtm 🤵
Use proto files from kuksa-databroker instead of kuksa.val
This should not make any practical difference as the files as of today should be identical