Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokio broadcast::channel #95

Merged

Conversation

rafaeling
Copy link
Contributor

Issue -> #60

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 36 lines in your changes missing coverage. Please review.

Project coverage is 59.61%. Comparing base (5604aa9) to head (a89dc6e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/val.rs 43.75% 18 Missing ⚠️
databroker/src/broker.rs 70.27% 11 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 0.00% 5 Missing ⚠️
databroker/src/viss/v2/server.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   59.71%   59.61%   -0.11%     
==========================================
  Files          33       33              
  Lines       15906    15955      +49     
==========================================
+ Hits         9499     9512      +13     
- Misses       6407     6443      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling requested a review from argerus November 6, 2024 07:27
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
@erikbosch
Copy link
Contributor

Do not know how much it says, but I did a smoke test with a subscription with kuksa-client and it worked without problem.

databroker/src/broker.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling requested a review from argerus November 11, 2024 16:00
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
proto/kuksa/val/v2/val.proto Outdated Show resolved Hide resolved
proto/kuksa/val/v2/val.proto Outdated Show resolved Hide resolved
proto/kuksa/val/v2/val.proto Outdated Show resolved Hide resolved
proto/kuksa/val/v2/val.proto Outdated Show resolved Hide resolved
proto/kuksa/val/v2/val.proto Outdated Show resolved Hide resolved
@rafaeling rafaeling force-pushed the fix/use_tokio_broadcast_channel branch 2 times, most recently from cb68f84 to d468be9 Compare November 13, 2024 10:45
@argerus argerus changed the base branch from feature/databroker-api-v2 to main November 13, 2024 11:16
@argerus argerus force-pushed the fix/use_tokio_broadcast_channel branch from d468be9 to a89dc6e Compare November 13, 2024 11:17
@rafaeling rafaeling merged commit 7d93bac into eclipse-kuksa:main Nov 13, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants