Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe by id Integer32 implementation #81

Conversation

rafaeling
Copy link
Contributor

A variation of the Subscribe method which improves performance by using an Integer32 ID instead of a string for signals parameter.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 83.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 55.33%. Comparing base (7b47ed9) to head (a8df2f6).
Report is 4 commits behind head on feature/databroker-api-v2.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/val.rs 83.33% 33 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/databroker-api-v2      #81      +/-   ##
=============================================================
+ Coverage                      54.99%   55.33%   +0.33%     
=============================================================
  Files                             33       33              
  Lines                          14525    14677     +152     
=============================================================
+ Hits                            7988     8121     +133     
- Misses                          6537     6556      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good not tested yet. Just one comment. Will try to test and start today as well.

databroker/src/grpc/kuksa_val_v2/val.rs Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is PR is changing way more than necessary. Databroker already supports the concept of using id instead path to refer to signals.

This is for example used by providers in the sdv.databroker.v1 interface.

To add support for this in kuksa.val.v2, you should in theory only need to change stuff under grpc/kuksa_val_v2.

erikbosch
erikbosch previously approved these changes Oct 16, 2024
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@argerus argerus requested a review from erikbosch October 16, 2024 10:00
@argerus argerus dismissed erikbosch’s stale review October 16, 2024 10:02

This should not be merged

@erikbosch erikbosch force-pushed the feature/databroker-api-v2 branch from 2aecd5c to 7b47ed9 Compare October 22, 2024 07:53
@rafaeling rafaeling force-pushed the feature/subscribe_by_id_implementation branch 2 times, most recently from 8a605af to f1b9b71 Compare October 22, 2024 08:29
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch
Copy link
Contributor

@argerus - can you check if you are happy with it now

databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling force-pushed the feature/subscribe_by_id_implementation branch from a655241 to a8df2f6 Compare October 22, 2024 12:48
@rafaeling rafaeling merged commit d0424e9 into eclipse-kuksa:feature/databroker-api-v2 Oct 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants