Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFO3: Close subscription after expired token #12

Merged
merged 4 commits into from
Apr 24, 2024
Merged

INFO3: Close subscription after expired token #12

merged 4 commits into from
Apr 24, 2024

Conversation

lukasmittag
Copy link
Contributor

@lukasmittag lukasmittag requested a review from argerus April 10, 2024 11:18
@lukasmittag lukasmittag force-pushed the fix/databroker/info_3 branch from b3779bb to 942bbf0 Compare April 10, 2024 11:21
@lukasmittag lukasmittag changed the title Close subscription after expired token INFO3: Close subscription after expired token Apr 10, 2024
argerus
argerus requested changes Apr 10, 2024
View reviewed changes
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
@lukasmittag lukasmittag force-pushed the fix/databroker/info_3 branch from 0fd6633 to 64f0cf6 Compare April 12, 2024 14:03
@lukasmittag lukasmittag requested a review from argerus April 12, 2024 14:03
@lukasmittag lukasmittag force-pushed the fix/databroker/info_3 branch from 17ea444 to b8d4757 Compare April 17, 2024 16:15
argerus
argerus requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes (those related to mutable access) are not needed anymore, now that the introduction of Option<> has been reverted.

databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
@lukasmittag lukasmittag requested a review from argerus April 23, 2024 07:26
@lukasmittag lukasmittag force-pushed the fix/databroker/info_3 branch from 83e53ba to bba87bd Compare April 23, 2024 09:46
@lukasmittag lukasmittag force-pushed the fix/databroker/info_3 branch from bba87bd to a559660 Compare April 24, 2024 06:54
@lukasmittag lukasmittag merged commit e7bab5c into eclipse-kuksa:main Apr 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argerus argerus argerus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasmittag @argerus