Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use samllvec to reduce heap usage, use inline functions and general improvements #115

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rafaeling
Copy link
Contributor

Improved performance by around 6%

@rafaeling rafaeling changed the title Use samllvec to reduce heap use, use inline functions and general improvements Use samllvec to reduce heap usage, use inline functions and general improvements Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 78.35821% with 29 lines in your changes missing coverage. Please review.

Project coverage is 59.62%. Comparing base (bfcb1e4) to head (33e0d0b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/broker.rs 81.25% 15 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 0.00% 8 Missing ⚠️
databroker/src/viss/v2/server.rs 0.00% 5 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/val.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   59.62%   59.62%   -0.01%     
==========================================
  Files          33       33              
  Lines       16068    16113      +45     
==========================================
+ Hits         9581     9607      +26     
- Misses       6487     6506      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -62,6 +62,7 @@ lazy_static = "1.4.0"
thiserror = "1.0.47"
futures = { version = "0.3.28" }
async-trait = "0.1.82"
smallvec = "1.13.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you should update the lock file as well, or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants