-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sbom tools #3
Sbom tools #3
Conversation
4293261
to
8870fe3
Compare
@erikbosch there may be an error in pre-commit check?
that is the "end of file" fixer, but is this is are compressed binary files, they should not be touched |
2df8943
to
46838a6
Compare
Ok, it seems pre-commit uses a python package called
It seems a bug to tag something as "binary" and "text", but a anyways both are tagged (correctly) as gzip type as well I just excluded that |
For completeness sake raised an issue upstream pre-commit/identify#450 |
sbom-tools/Readme.md
Outdated
|
||
```yaml | ||
expressions: | ||
"Apache-2.0 OR MIT": "Apache-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikehaller - this could possibly be a solution for our "unlicense" discusssion the other day
Some minor comments, but I like it. I am thinking - shall we possibly have an "example" folder? I.e. an example input file, a README that describes exactly how to run it and the expected output result. Then we could later possibly add a check in CI that running the python script still works and still produce the same result |
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
46838a6
to
9e99dfe
Compare
Fixed comments. I added an example folder, but at this time opted to not check in and "Output" folder, because no tests yet, and I am not sure, whether we might still change the exact format of the output in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Refactoring, splitting the function of eclipse/kuksa.val#756 making it pip installable