Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performances issues for Rotative4ImagesSVGWorkspaceImageFigure #729

Open
GlennPlou opened this issue Jul 7, 2022 · 0 comments
Open

Performances issues for Rotative4ImagesSVGWorkspaceImageFigure #729

GlennPlou opened this issue Jul 7, 2022 · 0 comments

Comments

@GlennPlou
Copy link
Contributor

Performance issues were identified for the rotative svg case, the opening time of some diagrams increased by 50% between Capella 5.2 and 6.0. Yourkit analysis indicates that the problem may come from Rotative4ImagesSVGWorkspaceImageFigure.refreshFigure(WorkspaceImage) which takes a lot of time and resources, especially with the call to SVGFigure.contentChanged().

See also eclipse-capella/capella#2395
GlennPlou added a commit to GlennPlou/kitalpha that referenced this issue Jul 7, 2022
@GlennPlou
eclipse-kitalpha#729 Set NONE orientation for Rotative4ImagesSVG
4875a21 
The first refresh at the initialization of the
Rotative4ImagesSVGWorkspaceImageFigure is not necessary as long as the
real orientation of the Figure has not been computed.

Change-Id: I7626adbf9b24071e2687f9456647b6e19610ab67
Signed-off-by: Glenn Plouhinec <[email protected]>
GlennPlou added a commit to GlennPlou/kitalpha that referenced this issue Jul 8, 2022
@GlennPlou
eclipse-kitalpha#729 Set NONE orientation for Rotative4ImagesSVG
4e82f37 
The first refresh at the initialization of the
Rotative4ImagesSVGWorkspaceImageFigure is not necessary as long as the
real orientation of the Figure has not been computed.

Change-Id: I7626adbf9b24071e2687f9456647b6e19610ab67
Signed-off-by: Glenn Plouhinec <[email protected]>
pdulth pushed a commit that referenced this issue Jul 15, 2022
@GlennPlou @pdulth
#729 Set NONE orientation for Rotative4ImagesSVG
52d3f58 
The first refresh at the initialization of the
Rotative4ImagesSVGWorkspaceImageFigure is not necessary as long as the
real orientation of the Figure has not been computed.

Change-Id: I7626adbf9b24071e2687f9456647b6e19610ab67
Signed-off-by: Glenn Plouhinec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GlennPlou