Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust Download with reattempt and retry #27

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Robust Download with reattempt and retry #27

merged 4 commits into from
Aug 26, 2022

Conversation

gboyvalenkov-bosch
Copy link
Contributor

[#23] Robust Download with reattempt and retry

  • implementation only

Signed-off-by: Georgi Boyvalenkov [email protected]

@gboyvalenkov-bosch
[eclipse-kanto#23] Robust Download with reattempt and retry
ad7b4d6 
- implementation only

Signed-off-by: Georgi Boyvalenkov <[email protected]>
@e-grigorov e-grigorov linked an issue Aug 25, 2022 that may be closed by this pull request
Robust Download with reattempt and retry #23
Closed
@e-grigorov
Copy link
Contributor

@gboyvalenkov-bosch The Eclipse Kanto project is currently restructuring its license scheme - from Eclipse Public License 2.0 only to dual licensing under Eclipse Public License 2.0 and Apache License 2.0 (you can read more about it here).

This contribution will be merged into the project with this new licensing scheme so its important for the project and the community to have your agreement on proceeding with it given these new circumstances 😊

Please, provide your feedback as a comment here that you, as an author of this contribution, understand and agree with the change explained above. Thank you!

@gboyvalenkov-bosch
Copy link
Contributor Author

@gboyvalenkov-bosch The Eclipse Kanto project is currently restructuring its license scheme - from Eclipse Public License 2.0 only to dual licensing under Eclipse Public License 2.0 and Apache License 2.0 (you can read more about it here).

This contribution will be merged into the project with this new licensing scheme so its important for the project and the community to have your agreement on proceeding with it given these new circumstances 😊

Please, provide your feedback as a comment here that you, as an author of this contribution, understand and agree with the change explained above. Thank you!

I understand and agree with the license change explained above.

e-grigorov
e-grigorov suggested changes Aug 25, 2022
View reviewed changes
internal/feature.go Outdated Show resolved Hide resolved
internal/flags.go Show resolved Hide resolved
internal/flags.go Outdated Show resolved Hide resolved
internal/flags.go Outdated Show resolved Hide resolved
internal/storage/download.go Outdated Show resolved Hide resolved
internal/storage/download.go Outdated Show resolved Hide resolved
@gboyvalenkov-bosch
[eclipse-kanto#23] Robust Download with reattempt and retry
85cdbb0 
- downloadRetryInterval uses duration type
- other minor improvements

Signed-off-by: Georgi Boyvalenkov <[email protected]>
e-grigorov
e-grigorov suggested changes Aug 25, 2022
View reviewed changes
internal/duration.go Outdated Show resolved Hide resolved
internal/feature_download.go Outdated Show resolved Hide resolved
internal/feature_install.go Outdated Show resolved Hide resolved
internal/storage/download.go Show resolved Hide resolved
@gboyvalenkov-bosch
[eclipse-kanto#23] Robust Download with reattempt and retry
90a6ba9 
- minor improvements and optimizations

Signed-off-by: Georgi Boyvalenkov <[email protected]>
e-grigorov
e-grigorov suggested changes Aug 26, 2022
View reviewed changes
internal/duration.go Outdated Show resolved Hide resolved
internal/flags.go Outdated Show resolved Hide resolved
internal/flags.go Outdated Show resolved Hide resolved
@gboyvalenkov-bosch
[eclipse-kanto#23] Robust Download with reattempt and retry
5691df1 
- flag description improvements

Signed-off-by: Georgi Boyvalenkov <[email protected]>
@e-grigorov e-grigorov merged commit 3a1a60e into eclipse-kanto:main Aug 26, 2022
@e-grigorov e-grigorov deleted the robust-download branch August 26, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-grigorov e-grigorov e-grigorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robust Download with reattempt and retry
2 participants
@gboyvalenkov-bosch @e-grigorov