-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common logic for device resources #207
Conversation
Signed-off-by: Antonia Avramova <[email protected]>
integration/util/registry.go
Outdated
return devicesVia, ok | ||
} | ||
|
||
func deleteDigitalTwinThings(cfg *TestConfiguration, things []string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return an error(any of them, if multiple) or pass testing.T as argument
integration/util/registry.go
Outdated
fmt.Printf("error restarting %s: %v", service, err) | ||
return false | ||
} | ||
fmt.Println(string(stdout)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider passing testing.T and logging the output
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golint reports:
registry.go:22:6: exported type Resource should have comment or be unexported
registry.go:34:6: exported type BootstrapConfiguration should have comment or be unexported
registry.go:46:6: exported type ConnectorConfiguration should have comment or be unexported
registry.go:57:28: func parameter newDeviceId should be newDeviceID
registry.go:92:3: struct field AuthId should be AuthID
registry.go:102:69: func parameter deviceId should be deviceID
Please fix it.
Signed-off-by: Antonia Avramova <[email protected]>
[#206] Common logic for device resources
Signed-off-by: Antonia Avramova [email protected]