Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common logic for device resources #207

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

antonia-avramova
Copy link
Contributor

@antonia-avramova antonia-avramova commented Feb 28, 2023

[#206] Common logic for device resources

Signed-off-by: Antonia Avramova [email protected]

Signed-off-by: Antonia Avramova <[email protected]>
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
return devicesVia, ok
}

func deleteDigitalTwinThings(cfg *TestConfiguration, things []string) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return an error(any of them, if multiple) or pass testing.T as argument

integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
fmt.Printf("error restarting %s: %v", service, err)
return false
}
fmt.Println(string(stdout))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider passing testing.T and logging the output

integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/web.go Outdated Show resolved Hide resolved
@k-gostev k-gostev linked an issue Mar 6, 2023 that may be closed by this pull request
Signed-off-by: Antonia Avramova <[email protected]>
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/web.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
Signed-off-by: Antonia Avramova <[email protected]>
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
integration/util/web.go Outdated Show resolved Hide resolved
integration/util/registry.go Outdated Show resolved Hide resolved
Signed-off-by: Antonia Avramova <[email protected]>
Signed-off-by: Antonia Avramova <[email protected]>
Copy link
Contributor

@k-gostev k-gostev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golint reports:

registry.go:22:6: exported type Resource should have comment or be unexported
registry.go:34:6: exported type BootstrapConfiguration should have comment or be unexported
registry.go:46:6: exported type ConnectorConfiguration should have comment or be unexported
registry.go:57:28: func parameter newDeviceId should be newDeviceID
registry.go:92:3: struct field AuthId should be AuthID
registry.go:102:69: func parameter deviceId should be deviceID

Please fix it.

Signed-off-by: Antonia Avramova <[email protected]>
@k-gostev k-gostev merged commit d6e3637 into eclipse-kanto:main Mar 15, 2023
@k-gostev k-gostev deleted the device-resources branch March 15, 2023 09:55
@k-gostev k-gostev restored the device-resources branch June 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common logic for device resources
3 participants