-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cloud2edge setup script for integration testing #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
reviewed
Sep 14, 2022
refi64
reviewed
Sep 14, 2022
refi64
reviewed
Sep 16, 2022
dimiter-todorov-georgiev
force-pushed
the
c2esetup
branch
from
October 19, 2022 06:42
3ddfeb0
to
0305e6e
Compare
refi64
reviewed
Oct 19, 2022
refi64
reviewed
Oct 19, 2022
e-grigorov
changed the title
[#126] Added cloud2edge setup script for integration testing
Added cloud2edge setup script for integration testing
Oct 28, 2022
e-grigorov
suggested changes
Oct 31, 2022
refi64
reviewed
Nov 2, 2022
dimiter-todorov-georgiev
force-pushed
the
c2esetup
branch
from
November 14, 2022 11:02
a37edb0
to
d11745e
Compare
dimiter-todorov-georgiev
force-pushed
the
c2esetup
branch
2 times, most recently
from
November 25, 2022 10:17
c0a9c9a
to
341b819
Compare
…ting Signed-off-by: Nikola Zhechev <[email protected]>
…nfigurable Signed-off-by: Nikola Zhechev <[email protected]>
Signed-off-by: Nikola Zhechev <[email protected]>
…operties Signed-off-by: Nikola Zhechev <[email protected]>
…lt values Signed-off-by: Nikola Zhechev <[email protected]>
Generate a random device ID on setup Read thing ID from MQTT on cleanup Restart suite-connector on setup and cleanup Keep a backup for suite-connector/config.json on setup and restore it on cleanup Delete dependent things on clean-up Signed-off-by: Dimiter Georgiev <[email protected]>
…lon in the prefix Signed-off-by: Dimiter Georgiev <[email protected]>
and instead get the policy ID on the command line Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
- Rename Hono environment variables to DeviceRegistryApi - Rename Ditto environment variables to DigitalTwinApi - Improved help output - Improved debug output - Changed command line flags - deviceID becomes device, policyID becomes policy - to match tenant. cleanup becomes clean - Refactored code according to code review feedback - Suite Connector's configuration is restored and the service restarted before deleting devices and things - Devices and things are now properly deleted in reversed order of creation - No longer requiring the tenant param on performing clean - Improved automatic discovery of related things and devices by looking at Hono JSON data instead of checking a name prefix Signed-off-by: Dimiter Georgiev <[email protected]>
- Preserve the file mode of suite-connector's configuration file - Improve error handling on file saving Signed-off-by: Dimiter Georgiev <[email protected]>
- Use the supplied deviceId and tenancyId, if both are present. Otherwise, if one is missing, read both of them from the local MQTT - Abort the setup procedure if the device with the current deviceId already exists in the device registry (Hono) - Check if the device was created in the registry, after creating all reasources Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
…ion backup parameters optional Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
- corrected go module name to github.com/eclipse-kanto/kanto/integration/c2esetup - corrected command line parameters to match suite-connector configuration names as per https://websites.eclipseprojects.io/kanto/docs/references/connectivity/suite-connector-config/ Signed-off-by: Dimiter Georgiev <[email protected]>
…tionality in the common integration test logic. Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
dimiter-todorov-georgiev
force-pushed
the
c2esetup
branch
from
November 25, 2022 13:49
c469893
to
2c12e6d
Compare
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
e-grigorov
suggested changes
Nov 28, 2022
- Rearrange the global variables to match the suite-connector configuration structure. - Remove unused global variables. - Remove empty string defaults for environment variables. - Renamed certFile to caCert, to match the suite-connector configuration structure. - Renamed devicePass to password, to match the suite-connector configuration structure. - Disconnect the MQTT client when done with it. - Improved error printing. - Improved verification of created device in the device registry. - Use bool ok instead of int code for passing success/failure between function calls. - Don't exit the process from a function call outside of main(). - Delete the already created backup file when an error occurs, in all cases. - Imrpoved handling of file mode on file copy. - Stop using the deprecated ioutil package in favor of equivalent calls from the package os. - Minor refactoring and vairable renaming based on code review comments. Signed-off-by: Dimiter Georgiev <[email protected]>
- Only check if there's any response for the device existence safety check. - Stop validating the device creation if the REST API is successful. Signed-off-by: Dimiter Georgiev <[email protected]>
e-grigorov
reviewed
Nov 28, 2022
e-grigorov
reviewed
Nov 28, 2022
- Use cfg.MqttQuiesceMs instead of a hardcoded value. Signed-off-by: Dimiter Georgiev <[email protected]>
e-grigorov
reviewed
Nov 29, 2022
e-grigorov
reviewed
Nov 29, 2022
- Change the initial capacity of a slice to 3, down from 4, because we're only appending 3 times to it. Signed-off-by: Dimiter Georgiev <[email protected]>
- Remove a redundant if statement. Signed-off-by: Dimiter Georgiev <[email protected]>
e-grigorov
reviewed
Nov 29, 2022
e-grigorov
reviewed
Nov 29, 2022
- Add failure checks and propagation on cleanup. - Add dependencies to NOTICE.md. Signed-off-by: Dimiter Georgiev <[email protected]>
- Slight refactoring. - Re-arrange and touch-up NOTICE.md. Signed-off-by: Dimiter Georgiev <[email protected]>
…ICE.md. Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
Signed-off-by: Dimiter Georgiev <[email protected]>
e-grigorov
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#126] Add cloud2edge setup script for integration testing
Signed-off-by: Nikola Zhechev [email protected]