Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite initializer must fail the test if thing configuration cannot be obtained #183

Closed
gboyvalenkov-bosch opened this issue Nov 25, 2022 · 0 comments · Fixed by #184
Closed

Suite initializer must fail the test if thing configuration cannot be obtained #183

gboyvalenkov-bosch opened this issue Nov 25, 2022 · 0 comments · Fixed by #184
Assignees
@gboyvalenkov-bosch
Labels
bug Something isn't working
Milestone
M3

Comments

@gboyvalenkov-bosch
Copy link
Contributor

gboyvalenkov-bosch commented Nov 25, 2022 •
edited
Loading

Currently, if thing configuration cannot be obtained in Setup method, tear down is called immediately, but the test does not fail.

suite.ThingCfg, err = GetThingConfiguration(cfg, mqttClient)
if err != nil {
	suite.TearDown()
}

This should be fixed with adding a fail/require statement.
@e-grigorov e-grigorov added the bug Something isn't working label Nov 25, 2022
@e-grigorov e-grigorov moved this to Todo in Eclipse Kanto Nov 25, 2022
@e-grigorov e-grigorov added this to the M3 milestone Nov 25, 2022
gboyvalenkov-bosch added a commit to bosch-io/kanto that referenced this issue Nov 25, 2022
@gboyvalenkov-bosch
[eclipse-kanto#183] Suite initializer must fail the test if thing con…
69b948a 
…figuration cannot be obtained

- bug fixed

Signed-off-by: Georgi Boyvalenkov <[email protected]>
@gboyvalenkov-bosch gboyvalenkov-bosch mentioned this issue Nov 25, 2022
Merged
@gboyvalenkov-bosch gboyvalenkov-bosch moved this from Todo to In Progress (max 10) in Eclipse Kanto Nov 25, 2022
@gboyvalenkov-bosch gboyvalenkov-bosch moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Nov 25, 2022
@e-grigorov e-grigorov linked a pull request Nov 25, 2022 that will close this issue
Suite initializer must fail the test if thing configuration cannot be obtained #184
Merged
@e-grigorov e-grigorov moved this from Ready for Review (max 3) to In Review (max 3) in Eclipse Kanto Nov 25, 2022
e-grigorov pushed a commit that referenced this issue Nov 25, 2022
@gboyvalenkov-bosch
[#183] Suite initializer must fail the test if thing configuration ca…
56b32f6 
…nnot be obtained (#184)

[#183] Suite initializer must fail the test if thing configuration cannot be obtained

Signed-off-by: Georgi Boyvalenkov <[email protected]>
Repository owner moved this from In Review (max 3) to Done in Eclipse Kanto Nov 25, 2022
@gboyvalenkov-bosch gboyvalenkov-bosch moved this from Done to In Review (max 3) in Eclipse Kanto Nov 25, 2022
@gboyvalenkov-bosch gboyvalenkov-bosch moved this from In Review (max 3) to Done in Eclipse Kanto Nov 25, 2022
Closed
This was referenced Nov 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gboyvalenkov-bosch gboyvalenkov-bosch

Labels
bug Something isn't working
Projects
Eclipse Kanto
Status: Done
Milestone
M3
Development

Successfully merging a pull request may close this issue.

Suite initializer must fail the test if thing configuration cannot be obtained bosch-io/kanto
2 participants
@e-grigorov @gboyvalenkov-bosch