Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test the resources clean up implementation #53

Closed
konstantina-gramatova opened this issue Sep 19, 2022 · 0 comments · Fixed by #54
Closed

Unit test the resources clean up implementation #53

konstantina-gramatova opened this issue Sep 19, 2022 · 0 comments · Fixed by #54
Assignees
@konstantina-gramatova
Labels
task Single unit of work
Milestone
M2

Comments

@konstantina-gramatova
Copy link
Contributor

The resources clean up logic has impacted the existing containerd client implementation and the newly introduced resources monitoring mechanism for expiry.

All must be covered with appropriate unit testing to ensure the expected behavior.
@konstantina-gramatova konstantina-gramatova changed the title Unit test the reseources clean up implementation Unit test the resources clean up implementation Sep 19, 2022
@konstantina-gramatova konstantina-gramatova self-assigned this Sep 19, 2022
@konstantina-gramatova konstantina-gramatova added the task Single unit of work label Sep 19, 2022
@konstantina-gramatova konstantina-gramatova added this to the M2 milestone Sep 19, 2022
@konstantina-gramatova konstantina-gramatova moved this from Todo to In Progress in Eclipse Kanto Sep 19, 2022
Closed
konstantina-gramatova added a commit to bosch-io/container-management that referenced this issue Sep 19, 2022
@konstantina-gramatova
[eclipse-kanto#53] Unit test the resources clean up implementation
0b706c0 
Covered the containerd client internal logic.
Covered the resources monitoring mechanism.
Optimized watched resources disposal.
Improved input parameters readability for the containerd internal client initialization.

Signed-off-by: Konstantina Gramatova <[email protected]>
Merged
@konstantina-gramatova konstantina-gramatova linked a pull request Sep 19, 2022 that will close this issue
Unit test the resources clean up implementation #54
Merged
konstantina-gramatova added a commit to bosch-io/container-management that referenced this issue Sep 19, 2022
@konstantina-gramatova
[eclipse-kanto#53] Unit test the resources clean up implementation
0dd0b8a 
Aligned the containerd SPI API.

Signed-off-by: Konstantina Gramatova <[email protected]>
@konstantina-gramatova konstantina-gramatova moved this from In Progress to Ready for Review in Eclipse Kanto Sep 19, 2022
@e-grigorov e-grigorov moved this from Ready for Review to In Review in Eclipse Kanto Sep 20, 2022
konstantina-gramatova added a commit to bosch-io/container-management that referenced this issue Sep 20, 2022
@konstantina-gramatova
[eclipse-kanto#53] Unit test the resources clean up implementation
76677b0 
Fixed typos and namings.

Signed-off-by: Konstantina Gramatova <[email protected]>
e-grigorov pushed a commit that referenced this issue Sep 20, 2022
@konstantina-gramatova
Unit test the resources clean up implementation (#54)
98b8400 
[#53] Unit test the resources clean up implementation

Covered the containerd client internal logic.
Covered the resources monitoring mechanism.
Optimized watched resources disposal.
Improved input parameters readability for the containerd internal client initialization.
Aligned the containerd SPI API.

Signed-off-by: Konstantina Gramatova <[email protected]>
Repository owner moved this from In Review to Done in Eclipse Kanto Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konstantina-gramatova konstantina-gramatova

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M2
Development

Successfully merging a pull request may close this issue.

Unit test the resources clean up implementation bosch-io/container-management
1 participant
@konstantina-gramatova