Fix #756: Service re-apply error happening during k8s:watch
#757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=========================================
Coverage 46.21% 46.21%
+ Complexity 3246 3245 -1
=========================================
Files 413 413
Lines 19856 19856
Branches 2781 2781
=========================================
Hits 9176 9176
Misses 9661 9661
Partials 1019 1019
Continue to review full report at Codecov.
|
|
Please check and add references to the changes in the Fabric8 Kubernetes Client project that made this changes required. |
rohanKanojia
force-pushed
the
pr/fix-watcher-issue
branch
from
00c878f to
716cc62
Compare
|
manusa
approved these changes
Jul 12, 2021
…atch` Use patch() instead of edit() in order to avoid 422 from APIServer. KubernetesClient no longer handles object modification in case of edit() when base object is provided. Signed-off-by: Rohan Kumar <[email protected]>
manusa
force-pushed
the
pr/fix-watcher-issue
branch
from
716cc62 to
f9b207b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #756
Use patch() instead of edit() since we don't seem to be making use of the
p(argument in UnaryOperator which is usually resource fetched from Server).Based on discussion here fabric8io/kubernetes-client#3221 (comment)
Signed-off-by: Rohan Kumar [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist