-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSecretIT Issue resolved #3500
FileSecretIT Issue resolved #3500
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #3500 (2024-12-19T11:01:53Z) ⚙️ JKube E2E Tests (12393419453)
|
Quality Gate passedIssues Measures |
As agreed internally @rohanKanojia will take a look into this PR and reported issue |
Signed-off-by: Puja <[email protected]>
4e48641
to
9ad251b
Compare
I'd add a note somewhere that what has the CRLF line endings is the base64 encoded application.properties. |
…d add a separate test for windows + Revert changes to FileDataSecretEnricher + Add a separate test for windows that would provide expected files with windows line endings Signed-off-by: Rohan Kumar <[email protected]>
9ad251b
to
8c7659e
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Fixes #3478
Type of change
test, version modification, documentation, etc.)
Checklist