fix (jkube-kit/common) : Update KubernetesHelper.exportKubernetesClientConfigToFile to add opinionated Cluster Context
#3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #3175 (2024-06-21T05:05:12Z) ⚙️ JKube E2E Tests (9608323558)
|
rohanKanojia
force-pushed
the
pr/3155/followup
branch
2 times, most recently
from
cd4766c to
787e087
Compare
18 tasks
manusa
requested changes
Jun 20, 2024
There was a problem hiding this comment.
This is not OK as it's making up settings in production code.
This should be (temporarily) done in a test helper class KubernetesMockServerHelper(?) in the jkube-kit/common/src/test test-jar.
- Open issue in KubernetesClient project indicating that the settings provided by the Kubernetes Mock Server are incomplete and missing the context and the current context.
- Add the temporary solution (similar implementation as done ATM) in JKube (referencing the upstream issue).
- Once the upstream issue is solved (in the future), remove the now unnecessary code.
rohanKanojia
force-pushed
the
pr/3155/followup
branch
from
787e087 to
105cb3f
Compare
…entConfigToFile` to add opinionated Cluster Context When using KubernetesClient with Kubernetes Mock Server, `kubernetesClient.getConfiguration()` returns a Config object with no context set. Handle this case in KubernetesMockServerUtil to create opinionated Context until this gets fixed in KubernetesMockServer Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/3155/followup
branch
from
105cb3f to
ef64498
Compare
Signed-off-by: Marc Nuri <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required by #3142
kubernetesClient.getConfiguration()returns a Config object with no context set.kubernetesClient.getConfiguration()does not provide any certificate data. When no certificate data is provided addInsecureSkipTlsVerifyoption in kubeconfigHandle this case in KubernetesHelper to create an opinionated Context until this gets fixed in KubernetesMockServer
Type of change
test, version modification, documentation, etc.)
Checklist