fix (jkube-kit) : lastModified timestamps should be preserved while preparing assembly #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2405 (2023-09-29T10:40:29Z) ⚙️ JKube E2E Tests (6349775425)
|
Codecov Report
@@ Coverage Diff @@
## master #2405 +/- ##
============================================
+ Coverage 59.36% 61.11% +1.74%
- Complexity 4586 4786 +200
============================================
Files 500 518 +18
Lines 21211 21394 +183
Branches 2830 2827 -3
============================================
+ Hits 12591 13074 +483
+ Misses 7370 7099 -271
+ Partials 1250 1221 -29
... and 67 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rohanKanojia
force-pushed
the
pr/preserve-lastmodifiedtimestamp-assembly
branch
3 times, most recently
from
c77ce8d to
1874fd2
Compare
manusa
reviewed
Sep 29, 2023
| @@ -169,8 +169,10 @@ private static List<AssemblyFileEntry> copy(Path sourceDirectory, File source, F | |||
| for (File sourceChild : Optional.ofNullable(source.listFiles()).orElse(new File[0])) { | |||
| copy(sourceDirectory, sourceChild, new File(target, sourceChild.getName()), assemblyFileSet); | |||
| } | |||
| FileUtil.updateLastModifiedTimestamp(target, source.lastModified()); | |||
There was a problem hiding this comment.
I think it'd be better if this was done as part of the copy.
Instead of adding an extra-function, just modify FileUtil.copy to preserve the original metadata
There was a problem hiding this comment.
OK, in this case target refers to the directoy.
Likewise, whatever process was used to create the directory should be used to preserve that timestamp.
I don't see the logic (besides for this current use-case) in updating the timestamp of an existent directory.
There was a problem hiding this comment.
Umm, you mean FileUtil.copy?
I noticed that whenever a new file gets added to directory, it's lastModified timestamp gets updated. This is done to revert directory's lastModified to original source's lastModified
rohanKanojia
force-pushed
the
pr/preserve-lastmodifiedtimestamp-assembly
branch
from
1874fd2 to
4702740
Compare
…reparing assembly We don't seem to be preserving lastModified timestamps of files that are being copied while preparing the assembly for image. Make sure we're copying all the metadata of files/directories as well while copying them. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/preserve-lastmodifiedtimestamp-assembly
branch
from
4702740 to
3a26d30
Compare
manusa
approved these changes
Sep 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't seem to be preserving lastModified timestamps of files that are being copied while preparing the assembly for image. Make sure we're copying all the metadata of files/directories as well while copying them.
Type of change
test, version modification, documentation, etc.)
Checklist