-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor (jkube-kit/config) : Sort BuildConfiguration fields by buildstrategy #2376
refactor (jkube-kit/config) : Sort BuildConfiguration fields by buildstrategy #2376
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2376 (2023-09-11T16:00:59Z) ⚙️ JKube E2E Tests (6148614552)
|
Codecov Report
@@ Coverage Diff @@
## master #2376 +/- ##
============================================
+ Coverage 59.36% 61.08% +1.71%
- Complexity 4586 4772 +186
============================================
Files 500 518 +18
Lines 21211 21385 +174
Branches 2830 2825 -5
============================================
+ Hits 12591 13062 +471
+ Misses 7370 7099 -271
+ Partials 1250 1224 -26
... and 62 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* <p> A provided {@link BuildConfiguration#from} takes precedence over the name given here. | ||
* This tag is useful for extensions of this plugin. | ||
* <p> | ||
* This field is applicable only for all build strategies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for this and every other field, This field is applicable only...
, the only
here is not OK
…strategy Sort all fields in BuildConfiguration class by applicable build strategies. Fields that are applicable to any build strategy are listed first. Then Docker specific buildstrategy fields are listed. Signed-off-by: Rohan Kumar <[email protected]>
2878b2f
to
0a41780
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs 100.0% Coverage The version of Java (11.0.18) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Description
Type of change
test, version modification, documentation, etc.)
Checklist