HelmServiceDependencyUpdateIT is failing on windows

[Sintivrousai]

Part of #1338

HelmServiceDependencyUpdateIT is failing on windows.

[ERROR] Failures:
[ERROR] HelmServiceDependencyUpdateIT$ValidChart.whenConfigurationOptionsProvided_thenDependencyDownloaded:97->verifyHelmDependencyDownloaded:113
Argument(s) are different! Wanted:

Can I work on that?

[rohanKanojia]

Hello, Sorry I didn't test this on windows while adding this test in #3098

Here are some code pointers to fix the test failures:

• whenInvalidChartDirProvided_thenThrowException : Test is failing due to a platform specific error message, maybe we can run this test only for Linux by adding @EnabledOnOs(OS.LINUX) annotation. You can also add same test that verifies message on Windows but that would only run on windows @EnabledOnOs(OS.WINDOWS)
• Other tests are failing due to helm CLI returning output with Line Feeds \n instead of CLRF \r\n on Windows. Here is screenshot
  

Here is the code that takes output of helm command and splits it based on System.lineSeparator() :

jkube/jkube-kit/helm/src/main/java/org/eclipse/jkube/kit/resource/helm/HelmService.java

Lines 186 to 189 in 6f644f8

	Arrays.stream(dependencyUpdateCommand.call()
	.split(System.lineSeparator()))
	.forEach(l -> logger.info("[[W]]%s", l));
	}

Test should pass when we update above mentioned code like this:

      String dependencyUpdateCommandOutput = dependencyUpdateCommand.call();
      String lineDelimiter = System.lineSeparator();
      if (!dependencyUpdateCommandOutput.contains(System.lineSeparator())) {
        lineDelimiter = "\n";
      }
      Arrays.stream(dependencyUpdateCommandOutput
          .split(lineDelimiter))
          .forEach(l -> logger.info("[[W]]%s", l));

[manusa]

Have we tried this:

   Arrays.stream(dependencyUpdateCommand.call() 
       .split("\r?\n") 
       .forEach(l -> logger.info("[[W]]%s", l)); 
 } 

[rohanKanojia]

Yeah, this is better.

[Sintivrousai]

Yeah, that part is okey but I'm encounering another issue.

[ERROR] Failures:
[ERROR] HelmServiceDependencyUpdateIT.whenInvalidChartDirProvided_thenThrowException:125
Expecting throwable message:
"could not find C:\Users\sindi\AppData\Local\Temp\junit11440685796248551667\output\kubernetes: CreateFile C:\Users\sindi\AppData\Local\Temp\junit11440685796248551667\output\kubernetes: The system cannot find the path specified."
to contain:
"no such file or directory"
but did not.

The part of the test that causes the problem is this:

@test
@DisplayName("invalid chart provided, then throw exception")
void whenInvalidChartDirProvided_thenThrowException() {
// When + Then
assertThatIllegalStateException()
.isThrownBy(() -> helmService.dependencyUpdate(helmConfig))
.withMessageContaining("no such file or directory");
}

Is this test required because I can't see such part in the HelmService.dependencyUpdate()?

[rohanKanojia]

@Sintivrousai see my comment #3121 (comment) . You can configure test to be run only in linux by adding @EnabledOnOs(OS.LINUX) annotation

• whenInvalidChartDirProvided_thenThrowException : Test is failing due to a platform-specific error message, maybe we can run this test only for Linux by adding @EnabledOnOs(OS.LINUX) annotation. You can also add same test that verifies message on Windows but that would only run on windows @EnabledOnOs(OS.WINDOWS)

[Sintivrousai]

oh i'm sorry i didn't see it