-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: helm-uninstall task/goal #2666
Comments
17 tasks
Shall we close this issue? |
Is it done? |
From what I can infer from issue description, these tasks have been completed
I don't think there is anything left to do in scope of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Helm: helm-uninstall task/goal
#2666
Description
As an Eclipse JKube user, I want to be able to uninstall a chart I've previously installed using
helm-install
, so that I can remove it from my Kubernetes/OpenShift cluster.Proposal
JKube Kit
JKube Kit exposes a new method
uninstall
that uninstalls the chart release with the name provided in theHelmConfig
argument (or the one inferred from the project's configuration).The chart should have been previously installed using the
install
method.uninstall
command.releaseName
:jkube.helm.release.name
Optional, if not specified, the release name should be inferred following the same procedure used to compute default image and resource names.
${installName} uninstalled
is logged.Maven plugins
The Kubernetes Maven Plugin and OpenShift Maven Plugin expose a new
helm-uninstall
goal in aHelmUninstallMojo
andOpenshiftHelmUninstallMojo
that extends the basicHelmMojo
(following a similar approach to that ofHelmPushMojo
andHelmLintMojo
).The mojos are bound by default to the
LifecyclePhase.INSTALL
phase.Tests should be added for each of the mojos and also for
KubernetesPluginTest
,OpenShiftPluginTest
, andGeneratedPluginDescriptorTest
.Gradle plugins
The Kubernetes Gradle Plugin and OpenShift Gradle Plugin expose a new
helmUninstall
task in aKubernetesHelmUninstallTask
andOpenShiftHelmUninstallTask
that extends the basicAbstractJKubeTask
task.Individual tests should be added for the new tasks and also for the plugins to verify task precedence.
An e2e test proves that the task can be executed both, with a successful and a failed installation.
Documentation
The documentation exposes for each of the Maven, Gradle, Kubernetes, and OpenShift plugins the new uninstall goal/task.
It includes a section with the (un)installation options that can be provided in the
HelmConfig
argument and properties.Documentation should be reviewed to replace any reference to the
helm uninstall
CLI command with the newhelm-uninstall
goal/task.If no such reference exists, maybe we should consider adding one, especially in the context of the
helm-install
goal/task.The text was updated successfully, but these errors were encountered: