Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JKube generators should be able to provide opinionated BuildPackConfiguration #2460

Closed
1 task
rohanKanojia opened this issue Nov 21, 2023 · 2 comments
Closed
1 task
Assignees
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

None

Task description

Description

Part of #439

Currently, our generators provide opinionated ImageConfiguration by inspecting project configuration.

As a user building container image leveraging buildpacks, JKube generators should be able to create opinionated BuildPackConfiguration along with ImageConfiguration. This should be supported for frameworks that have buildpacks supported officially.

Expected Behavior

As a user, when I build container image using buildpacks, I expect jkube generators to choose the appropriate buildpack builder image automatically. This should be applicable provided there is an officially supported buildpack available for a particular framework (spring-boot, quarkus)

Acceptance Criteria

  • JKube Generators should be able to configure BuildPackConfiguration aspects as per applicable frameworks
@manusa
Copy link
Member

manusa commented May 15, 2024

As discussed internally:

Choosing the buildpacks strategy is just telling JKube to delegate everything to buildpacks. JKube is only responsible for picking up the image name and creating suitable resources.

Maybe this can be more explicit in the docs. Stating that buildpacks strategy is a delegation and the user is completely responsible to provide a valid buildpacks configuration.

@manusa manusa moved this from In Progress to Planned in Eclipse JKube May 15, 2024
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 17, 2024
…legation to pack CLI

Related to eclipse-jkube#2460

Add note in BuildPacks Integration so that it's clear that it's user's
responsibility to provide a valid buildpacks configuration

Signed-off-by: Rohan Kumar <[email protected]>
manusa pushed a commit that referenced this issue May 17, 2024
…ion to pack CLI

Related to #2460

Add note in BuildPacks Integration so that it's clear that it's user's
responsibility to provide a valid buildpacks configuration

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia
Copy link
Member Author

Maybe this can be more explicit in the docs. Stating that buildpacks strategy is a delegation and the user is completely responsible to provide a valid buildpacks configuration.

We have updated the documentation addressing this aspect in #3069 . I think we can close this issue.

@manusa manusa added this to the 1.17.0 milestone May 28, 2024
@manusa manusa closed this as completed May 28, 2024
@github-project-automation github-project-automation bot moved this from Planned to Done in Eclipse JKube May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants