-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test : Add test to verify OpenShift trace logging works #353
Merged
manusa
merged 1 commit into
eclipse-jkube:main
from
rohanKanojia:pr/openshift-build-trace
Mar 8, 2024
Merged
test : Add test to verify OpenShift trace logging works #353
manusa
merged 1 commit into
eclipse-jkube:main
from
rohanKanojia:pr/openshift-build-trace
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/openshift-build-trace
branch
3 times, most recently
from
October 20, 2023 07:01
0b0b5ef
to
791743d
Compare
I think OpenShift E2E test failures are unrelated to changes in my PR. They seem to be failing during setup phase:
Maybe it's due to openshift/origin-control-plane image not found on dockerhub |
rohanKanojia
force-pushed
the
pr/openshift-build-trace
branch
from
November 2, 2023 03:11
791743d
to
00bb683
Compare
It should be possible to rebase this and see if the test passes in oc 3.10 now. |
rohanKanojia
force-pushed
the
pr/openshift-build-trace
branch
from
March 5, 2024 05:01
00bb683
to
72ace90
Compare
The test seems to hang on OpenShift |
I'll try to run it locally to see what's wrong. |
rohanKanojia
force-pushed
the
pr/openshift-build-trace
branch
12 times, most recently
from
March 7, 2024 17:07
612ed8f
to
fc2e43e
Compare
Related to eclipse-jkube/jkube#2211 + Add QuarkusOcTraceEnabledITCase to test suite which verifies openshift maven plugin goals with `org.slf4j.simpleLogger.defaultLogLevel` property set to trace + Add new test project `maven/quarkus/rest-trace-logging-enabled` for testing abovementioned integration test Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/openshift-build-trace
branch
from
March 7, 2024 17:49
fc2e43e
to
c2532a1
Compare
manusa
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to eclipse-jkube/jkube#2211
openshift maven plugin goals with
org.slf4j.simpleLogger.defaultLogLevel
property set to trace
maven/quarkus/rest-trace-logging-enabled
fortesting abovementioned integration test