Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test : Add test to verify OpenShift trace logging works #353

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Oct 19, 2023

Related to eclipse-jkube/jkube#2211

  • Add QuarkusOcTraceEnabledITCase to test suite which verifies
    openshift maven plugin goals with org.slf4j.simpleLogger.defaultLogLevel
    property set to trace
  • Add new test project maven/quarkus/rest-trace-logging-enabled for
    testing abovementioned integration test

@rohanKanojia rohanKanojia force-pushed the pr/openshift-build-trace branch 3 times, most recently from 0b0b5ef to 791743d Compare October 20, 2023 07:01
@rohanKanojia
Copy link
Member Author

I think OpenShift E2E test failures are unrelated to changes in my PR. They seem to be failing during setup phase:

Pulling image openshift/origin-control-plane:v3.10
error: error pulling Docker image openshift/origin-control-plane:v3.10
Error: Command failed: oc cluster up --routing-suffix="127.0.0.1.${OC_DOMAIN:-nip.io}" 
    at checkExecSyncError (node:child_process:861:11)
    at Object.execSync (node:child_process:932:15)
    at logExecSync (/home/runner/work/_actions/manusa/actions-setup-openshift/e59fe3caa18d7cde81e2ce4797e6549a13f7648c/src/exec.js:8:17)
    at clusterUp (/home/runner/work/_actions/manusa/actions-setup-openshift/e59fe3caa18d7cde81e2ce4797e6549a13f7648c/src/install.js:16:3)
    at startCluster (/home/runner/work/_actions/manusa/actions-setup-openshift/e59fe3caa18d7cde81e2ce4797e6549a13f7648c/src/install.js:18:39)
    at install (/home/runner/work/_actions/manusa/actions-setup-openshift/e59fe3caa18d7cde81e2ce4797e6549a13f7648c/src/install.js:46:3)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async run (/home/runner/work/_actions/manusa/actions-setup-openshift/e59fe3caa18d7cde81e2ce4797e6549a13f7648c/src/index.js:16:3) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 70733,
  stdout: null,
  stderr: null
}
Error: Command failed: oc cluster up --routing-suffix="1[27](https://github.com/jkubeio/jkube-integration-tests/actions/runs/6584473456/job/17889210224?pr=353#step:7:28).0.0.1.${OC_DOMAIN:-nip.io}" 
Error: Command failed: oc cluster up --routing-suffix="127.0.0.1.${OC_DOMAIN:-nip.io}"

Maybe it's due to openshift/origin-control-plane image not found on dockerhub

@rohanKanojia rohanKanojia force-pushed the pr/openshift-build-trace branch from 791743d to 00bb683 Compare November 2, 2023 03:11
@manusa
Copy link
Member

manusa commented Mar 5, 2024

It should be possible to rebase this and see if the test passes in oc 3.10 now.

@rohanKanojia rohanKanojia force-pushed the pr/openshift-build-trace branch from 00bb683 to 72ace90 Compare March 5, 2024 05:01
@manusa
Copy link
Member

manusa commented Mar 6, 2024

The test seems to hang on OpenShift

@rohanKanojia
Copy link
Member Author

I'll try to run it locally to see what's wrong.

@rohanKanojia rohanKanojia force-pushed the pr/openshift-build-trace branch 12 times, most recently from 612ed8f to fc2e43e Compare March 7, 2024 17:07
Related to eclipse-jkube/jkube#2211

+ Add QuarkusOcTraceEnabledITCase to test suite which verifies
  openshift maven plugin goals with `org.slf4j.simpleLogger.defaultLogLevel`
  property set to trace
+ Add new test project `maven/quarkus/rest-trace-logging-enabled` for
  testing abovementioned integration test

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/openshift-build-trace branch from fc2e43e to c2532a1 Compare March 7, 2024 17:49
@rohanKanojia rohanKanojia marked this pull request as ready for review March 8, 2024 04:29
@rohanKanojia rohanKanojia requested a review from manusa March 8, 2024 04:39
@manusa manusa merged commit ca5dbfb into eclipse-jkube:main Mar 8, 2024
25 checks passed
@rohanKanojia rohanKanojia deleted the pr/openshift-build-trace branch March 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants