fix: commit check failure

.gitignore

@@ -26,4 +26,6 @@ k8s/*.tgz
 cloud/
 *.tgz
 
-bin
+bin
+
+.test-temp

analysis/heap-dump/eclipse-mat-deps/eclipse-mat-deps.gradle

@@ -89,5 +89,4 @@ afterEvaluate {
     jarNames.add('heap-dump-analysis-impl-' + version + '.jar')
     def listFileName = 'list'
     Files.writeString(depsDirPath.resolve(listFileName), jarNames.stream().collect(Collectors.joining(",")))
-    println depsDirPath.resolve(listFileName).toAbsolutePath().toString()
 }

analysis/heap-dump/impl/src/test/java/org/eclipse/jifa/hda/impl/TestHeapDumpAnalyzerImpl.java

@@ -14,11 +14,13 @@
 
 import com.sun.management.HotSpotDiagnosticMXBean;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.io.FileUtils;
 import org.eclipse.jifa.analysis.listener.ProgressListener;
 import org.eclipse.jifa.hda.api.HeapDumpAnalyzer;
 import org.eclipse.jifa.hda.api.Model;
 import org.eclipse.jifa.hda.api.SearchType;
 import org.eclipse.jifa.hdp.provider.HeapDumpAnalysisApiExecutor;
+import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
@@ -32,19 +34,18 @@
 @Slf4j
 public class TestHeapDumpAnalyzerImpl {
 
+    private static Path DIRECTORY;
+
     private static HeapDumpAnalyzer ANALYZER;
 
     @BeforeAll
     public static void init() throws Exception {
         // init environment
-        Path heapFile = Files.createTempFile("test-heap", ".hprof").toAbsolutePath();
+        DIRECTORY = Files.createTempDirectory("test-heap-dir");
+        Path heapFile = Files.createTempFile(DIRECTORY, "test-heap", ".hprof").toAbsolutePath();
         Files.delete(heapFile);
         HotSpotDiagnosticMXBean platformMXBean = ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
         platformMXBean.dumpHeap(heapFile.toString(), false);
-        if (Files.exists(heapFile)) {
-            log.info("Heap dump file: {}", heapFile);
-            heapFile.toFile().deleteOnExit();
-        }
         Method buildAnalyzer = HeapDumpAnalysisApiExecutor.class.getDeclaredMethod("buildAnalyzer", Path.class, Map.class, ProgressListener.class);
         buildAnalyzer.setAccessible(true);
         ANALYZER = (HeapDumpAnalyzer) buildAnalyzer.invoke(new HeapDumpAnalysisApiExecutor(),
@@ -53,6 +54,13 @@ public static void init() throws Exception {
                                                            ProgressListener.NoOpProgressListener);
     }
 
+    @AfterAll
+    public static void clean() {
+        if (DIRECTORY != null) {
+            FileUtils.deleteQuietly(DIRECTORY.toFile());
+        }
+    }
+
     @Test
     public void testGetDetails() {
         ANALYZER.getDetails();

analysis/heap-dump/provider/src/main/java/org/eclipse/jifa/hdp/provider/HeapDumpAnalysisApiExecutor.java

@@ -84,13 +84,19 @@ public class HeapDumpAnalysisApiExecutor extends AbstractApiExecutor<HeapDumpAna
 
             String osgiWorkspace = path + "/osgi_workspace";
             String osgiConfiguration = path + "/osgi_configuration";
+
             if (Files.exists(Path.of(osgiWorkspace))) {
                 FileUtils.deleteQuietly(new File(osgiWorkspace));
             }
             if (Files.exists(Path.of(osgiConfiguration))) {
                 FileUtils.deleteQuietly(new File(osgiConfiguration));
             }
 
+            Runtime.getRuntime().addShutdownHook(new Thread(() -> {
+                FileUtils.deleteQuietly(new File(osgiWorkspace));
+                FileUtils.deleteQuietly(new File(osgiConfiguration));
+            }));
+
             config.put(EquinoxLocations.PROP_INSTANCE_AREA_DEFAULT, osgiWorkspace);
             config.put(Location.CONFIGURATION_AREA_TYPE, osgiConfiguration);
 

gradle/java.gradle

@@ -46,8 +46,18 @@ java {
     compile.options.compilerArgs << '-parameters'
 }
 
+def testTempPath = rootProject.projectDir.toPath().toAbsolutePath().resolve('.test-temp')
+if (!testTempPath.toFile().exists()) {
+    testTempPath.toFile().mkdir()
+}
+
 test {
+    testLogging.showStandardStreams = true
     useJUnitPlatform()
+
+    systemProperty 'java.io.tmpdir', testTempPath.toString()
+    systemProperty 'jdk.util.zip.disableZip64ExtraFieldValidation', true
+
     finalizedBy jacocoTestReport
 }