Adding annotation processing support #616
Conversation
|
I'm still torn whether to enable AP by default |
|
This is great! 🎉 I'm currently working on a some code which makes heavy use of annotations using Vim and YouCompleteMe with the Java completer, and the lack of annotation processing results in all kinds of weird errors. |
|
I've enabled m2e-apt by default, as I think it provides better UX. We'll see how it behaves over time. In the mean time, I opened CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16186 |
| new DiagnosticsHandler(connection, unit).clearDiagnostics(); | ||
| } | ||
| if (unit.equals(sharedASTProvider.getActiveJavaElement())) { | ||
| sharedASTProvider.disposeAST(); | ||
| } | ||
| unit.discardWorkingCopy(); | ||
| unit.getResource().refreshLocal(IResource.DEPTH_ZERO, null); |
There was a problem hiding this comment.
Why do we need a refresh before closing?
There was a problem hiding this comment.
That should no longer be needed. IIRC, before derived resources where ignored, the client would mess with those compilation units after being modified server-side, and causing errors that would not be discarded after closing the derived file.
- adds m2e-apt to the server distro (requires CQ approval) - ignores derived resources from didOpen/didChange/didSave calls, effectively removing diagnostics for those, as, after the server generates those files, the client detects changes, so sends textedits to the server to re-modify them, causing weird errors. Signed-off-by: Fred Bricon <[email protected]>
fbricon
changed the title
|
Updated PR |
|
CQ was approved by the IP team |
Fixes #128
Signed-off-by: Fred Bricon [email protected]