Refresh with one depth when calling JDTUtils.getFileOrFolder() #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <[email protected]>
testforstephen
approved these changes
Oct 12, 2019
jdneo
force-pushed
the
cs/refresh-local
branch
from
04e174a to
8551c84
Compare
Signed-off-by: Sheng Chen <[email protected]>
jdneo
force-pushed
the
cs/refresh-local
branch
from
8551c84 to
879f82a
Compare
| final int originalMemberNum = ((IFolder) parent).members().length; | ||
|
|
||
| File newPackage = new File(project.getLocation().toString(), "/src/org/eclipse/testGetFileOrFolder"); | ||
| newPackage.mkdirs(); |
There was a problem hiding this comment.
will the new package be cleaned up after the test done?
There was a problem hiding this comment.
|
test this please |
|
I tried locally, the newly added test will fail if the refresh depth is |
|
Thnanks @jdneo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1137
Signed-off-by: Sheng Chen [email protected]