Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find implementation intelligently fall back to find definition #1150

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

testforstephen
Copy link
Contributor

Signed-off-by: Jinbo Wang [email protected]

Fix #1098

If the find implementation happens at the position of method or type declaration, keeps old behavior.

If it happens at the position of method/type invocation, then follows the rules below to determine whether to include the definition to the result.

  • If the hovered element is an unimplemented member (abstract or interface) and no implementations are found in the workspace, then include the element definition to the result.
  • If the hovered element is non abstract or interface, then always include the element definition as the first result.

@testforstephen
Copy link
Contributor Author

test this please

1 similar comment
@testforstephen
Copy link
Contributor Author

test this please

@fbricon fbricon added this to the End August 2019 milestone Aug 21, 2019
@fbricon fbricon merged commit c654ebf into eclipse-jdtls:master Aug 21, 2019
@fbricon
Copy link
Contributor

fbricon commented Aug 21, 2019

Thanks @testforstephen !

@testforstephen testforstephen deleted the jinbo_implementation branch August 22, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find implementation doesn't work on classes
2 participants