Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom notifications #522

Closed
tsmaeder opened this issue Jan 18, 2018 · 1 comment
Closed

Allow custom notifications #522

tsmaeder opened this issue Jan 18, 2018 · 1 comment

Comments

@tsmaeder
Copy link
Contributor

While jdt.ls extenders can add functionality by adding custom commands, there is not such ability for notifications. As it happens, The remote proxy we get back from Launcher.getRemoteProxy() when starting the client connection in JavaLanguageServerPlugin#startConnection() implements "Endpoint". This would allow us to add a method to JDTLanguageServer like so:

public void notify(String method, Object parameter) {
  ((Endpoint)client).notify(method, parameter);
}

This would very simply allow custom notifications.

vrubezhny added a commit to vrubezhny/eclipse.jdt.ls that referenced this issue Mar 7, 2018
vrubezhny added a commit to vrubezhny/eclipse.jdt.ls that referenced this issue Mar 13, 2018
vrubezhny added a commit to vrubezhny/eclipse.jdt.ls that referenced this issue Mar 15, 2018
vrubezhny added a commit to vrubezhny/eclipse.jdt.ls that referenced this issue Mar 15, 2018
The public `void notify(String method, Object parameter)` method is added
to `JavaClientConnection` thus allowing sending the notifications from a
Server to a Client

Fixes eclipse-jdtls#522
Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny added a commit to vrubezhny/eclipse.jdt.ls that referenced this issue Mar 22, 2018
The public `void notify(String method, Object parameter)` method is added
to `JavaClientConnection` thus allowing sending the notifications from a
Server to a Client

Fixes eclipse-jdtls#522
Signed-off-by: Victor Rubezhny <[email protected]>
@fbricon
Copy link
Contributor

fbricon commented Mar 28, 2018

Superseded by #595

@fbricon fbricon closed this as completed Mar 28, 2018
@fbricon fbricon added this to the End March 2018 milestone Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants