Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Call Hierarchy #508

Closed
gorkem opened this issue Dec 24, 2017 · 11 comments · Fixed by #1306
Closed

Support for Call Hierarchy #508

gorkem opened this issue Dec 24, 2017 · 11 comments · Fixed by #1306
Labels
enhancement help wanted
Milestone
Mid December 2019

Comments

@gorkem
Copy link
Contributor

gorkem commented Dec 24, 2017

Add support for call hierarchies
@kittaakos
Copy link

I am volunteering for this.

The LSP part has been proposed via microsoft/vscode-languageserver-node#420.
I will also take care of the LSP4J implementation.

If this task is not yet taken, please assign to me. Thank you!

@kittaakos kittaakos mentioned this issue Jan 21, 2019
Closed
kittaakos referenced this issue Jan 22, 2019
@yaohaizh @fbricon
Adopt CodeAction & CodeActionKind protocol.
42e2183
@fbricon
Copy link
Contributor

fbricon commented Jan 22, 2019

@kittaakos sounds great! Seems I can't assign it to you, but feel free to start working on it

@kittaakos
Copy link

kittaakos commented Jan 24, 2019 •
edited
Loading

@fbricon, the org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchy class is in jdt.ui. Would it be sufficient to copy the UI classes into JDT LS for now and do the jdt.core.manipulation migration in a separate PR. Thank you!

kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 28, 2019
eclipse-jdtlsGH-508: Copied o.e.j.i.corext.callhierarchy source from …
ccf7771 
…JDT UI to LS.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 28, 2019
eclipse-jdtlsGH-508: Switched from JavaPlugin to `JavaLanguageServe…
c7ea1da 
…rPlugin`.

Also, reused the `StringMatcher` from the CA instead of `jdt.ui.util`.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 28, 2019
eclipse-jdtlsGH-508: Got rid of the Eclipse workbench dependencies.
33b0a71 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 28, 2019
eclipse-jdtlsGH-508: Added handler for textDocument/callHierarchy.
28cbc72 
Closes eclipse-jdtls#508

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Jan 28, 2019
Closed
@kittaakos
Copy link

Would it be sufficient to copy the UI classes into JDT LS for now

I've created a PR for this task. After copying the JDT UI code to the LS, I had to adjust the source in two relatively easy steps: c7ea1da, 33b0a71. (The rest is the actual implementation.) I would like to know how to proceed with the org.eclipse.jdt.internal.corext.callhierarchy package.

@fbricon
Copy link
Contributor

fbricon commented Jan 28, 2019

@jjohnstn @rgrunber how long before we could get those copied classes refactored to jdt.core?

@jjohnstn
Copy link
Contributor

It should be straightforward. Let me work on a patch.

kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 29, 2019
eclipse-jdtlsGH-508: Added support for call hierarchies.
1fc9053 
Closes eclipse-jdtls#508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 29, 2019
eclipse-jdtlsGH-508: Added support for call hierarchies.
8e94875 
Closes eclipse-jdtls#508

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link

Let me work on a patch.

Please note, I had to change the CallHierarchy.DEFAULT_IGNORE_FILTERS pattern from java.*,javax.* to an empty string. (Here is the change.) Please leave the default value as an empty string in the core or make it mutable. Thank you!

@jjohnstn
Copy link
Contributor

jjohnstn commented Feb 1, 2019

Patch submitted for review: https://git.eclipse.org/r/#/c/136044/

@Yanpas
Copy link

Yanpas commented Feb 1, 2019

I participate in ccls development, call and inheritance hierarchy code may be easily reused in vscode extension:
https://github.com/MaskRay/vscode-ccls/tree/master/src/hierarchies

@kittaakos
Copy link

I participate in ccls development, call and inheritance hierarchy code may be easily reused in vscode extension:
https://github.com/MaskRay/vscode-ccls/tree/master/src/hierarchies

@Yanpas, can you please give us some hints on how to reuse the extension? I would be interested in trying the LS feature in VS Code. Thank you!

@Yanpas
Copy link

Yanpas commented Feb 8, 2019

There is an abstract class for all kind of hierarchies (Hierarchy in hierarchy.ts) and it's implementations. What it does is it's hides/reveals hierarchy pane in explorer window via "context" variables, awaits for requests to language server and creates TreeItems. I don't know the internals of java ls, so not sure if it is dropin replacement (e.g. ccls uses subtree requests).

It is created in serverContext (instance of this class has the same lifetime as language server) and registered in registerTreeDataProvide.

@akaroml akaroml mentioned this issue Jun 20, 2019
Closed
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Copied o.e.j.i.corext.callhierarchy source from …
82134ea 
…JDT UI to LS.

Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Switched from JavaPlugin to `JavaLanguageServe…
c2fbe65 
…rPlugin`.

Also, reused the `StringMatcher` from the CA instead of `jdt.ui.util`.

Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Got rid of the Eclipse workbench dependencies.
d4dca3a 
Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Added support for call hierarchies.
b823ad8 
Closes eclipse-jdtls#508

Signed-off-by: Akos Kitta <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the new call hierarchy LSP
cbe6d96 
Signed-off-by: Jinbo Wang <[email protected]>
@testforstephen testforstephen mentioned this issue Dec 13, 2019
Merged
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 13, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the new call hierarchy LSP
70ac5fd 
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 16, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the new call hierarchy LSP
92bd75a 
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the upstream lsp4j snapshot for call hiera…
8dae866 
…rchy

Signed-off-by: Jinbo Wang <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Copied o.e.j.i.corext.callhierarchy source from …
119d6fc 
…JDT UI to LS.

Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Switched from JavaPlugin to `JavaLanguageServe…
066f626 
…rPlugin`.

Also, reused the `StringMatcher` from the CA instead of `jdt.ui.util`.

Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Got rid of the Eclipse workbench dependencies.
bc83f44 
Signed-off-by: Akos Kitta <[email protected]>
testforstephen pushed a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Added support for call hierarchies.
51ae939 
Closes eclipse-jdtls#508

Signed-off-by: Akos Kitta <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the new call hierarchy LSP
43c901e 
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Cache the method wrappers for call hierarchy
88a6599 
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the upstream lsp4j snapshot for call hiera…
0cf7521 
…rchy

Signed-off-by: Jinbo Wang <[email protected]>
testforstephen added a commit to testforstephen/eclipse.jdt.ls that referenced this issue Dec 18, 2019
@testforstephen
eclipse-jdtlsGH-508: Adopt the upstream lsp4j snapshot for call hiera…
d4dd35f 
…rchy

Signed-off-by: Jinbo Wang <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@fbricon
GH-508: Copied o.e.j.i.corext.callhierarchy source from JDT UI to LS.
1a8e640 
Signed-off-by: Akos Kitta <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@fbricon
GH-508: Switched from JavaPlugin to JavaLanguageServerPlugin.
e30b5e5 
Also, reused the `StringMatcher` from the CA instead of `jdt.ui.util`.

Signed-off-by: Akos Kitta <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@fbricon
GH-508: Got rid of the Eclipse workbench dependencies.
f1647bc 
Signed-off-by: Akos Kitta <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@fbricon
GH-508: Added support for call hierarchies.
2fe81cb 
Closes #508

Signed-off-by: Akos Kitta <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@testforstephen @fbricon
GH-508: Adopt the new call hierarchy LSP
6a71e5d 
Signed-off-by: Jinbo Wang <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@testforstephen @fbricon
GH-508: Cache the method wrappers for call hierarchy
bdea273 
Signed-off-by: Jinbo Wang <[email protected]>
fbricon pushed a commit that referenced this issue Dec 18, 2019
@testforstephen @fbricon
GH-508: Adopt the upstream lsp4j snapshot for call hierarchy
dd830b5 
Signed-off-by: Jinbo Wang <[email protected]>
@fbricon fbricon added this to the Mid December 2019 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
Mid December 2019
Development

Successfully merging a pull request may close this issue.

GH-508: Support Call Hierarchy testforstephen/eclipse.jdt.ls
5 participants
@gorkem @fbricon @jjohnstn @kittaakos @Yanpas