Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Type Hierarchy #28

Closed
guw opened this issue Jul 6, 2016 · 6 comments
Closed

Support for Type Hierarchy #28

guw opened this issue Jul 6, 2016 · 6 comments
Labels
enhancement

Comments

@guw
Copy link
Contributor

guw commented Jul 6, 2016

Probably needs extension of the protocol as well as in VScode?
@gorkem
Copy link
Contributor

gorkem commented Nov 26, 2016

See microsoft/language-server-protocol#136 for protocol discussions

yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this issue Jul 4, 2017
@fbricon
Fix eclipse-jdtls#28 add option to set the JDK home directory, from w…
fead866 
…hich to run the JLS

Signed-off-by: Fred Bricon <[email protected]>
fbricon pushed a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 21, 2017
@ansyral
Merge pull request eclipse-jdtls#28 from ansyral/imple
462fd0b 
add jdt language server info provider implementation
@tsmaeder tsmaeder mentioned this issue Sep 25, 2017
Closed
@fbricon fbricon mentioned this issue Sep 26, 2018
Closed
@Yanpas
Copy link

Yanpas commented Sep 26, 2018

Isn't this functionality already implemented is Eclipse? The only thing left to do is to expose LSP-RPC method.

@fbricon
Copy link
Contributor

fbricon commented Sep 26, 2018

It needs to be rewritten to decouple it from JDT UI. So, once we have standardized the protocol, then we'll refactor eclipse's internals for jdt.ls to conform to it

@Yanpas
Copy link

Yanpas commented Sep 26, 2018

You may implement it as cquery project did as protocol extension and then rename this method. The LSP proposal is already 2 years old and seems will be accepted only when vs code developers need it.

kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 2, 2018
eclipse-jdtlsGH-28: Updated TP to use a customized LSP4J.
b5954df 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 5, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
43ec377 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
5b7b7ed 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
47bbb3c 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
8e06e1e 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
092f294 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018
eclipse-jdtlsGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
97c814b 
Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 9, 2018
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
5334e0e 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Oct 9, 2018
Closed
@kittaakos
Copy link

PR: #823

kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 9, 2018
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
decc6f6 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 11, 2018
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
3efbce6 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 22, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
494b146 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 22, 2019
[eclipse-jdtlsGH-28]: !squash me! This is based on the LSP proposed b…
3533ab2 
…y MS.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 23, 2019
eclipse-jdtlsGH-28: Fixed the build. Moved the utilities to JDTUtils.
001a332 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 23, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
5bc2d86 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 24, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
1a018d9 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 25, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
0b0783f 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Jan 25, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
7888ade 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/eclipse.jdt.ls that referenced this issue Mar 5, 2019
eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…
3836c33 
…ies.

Closes: eclipse-jdtls#28.

Signed-off-by: Akos Kitta <[email protected]>
@fbricon
Copy link
Contributor

fbricon commented Sep 8, 2021

Was fixed 6 months ago with #1656

@fbricon fbricon closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-28: Added support for the super- and subtype hierarchies. kittaakos/eclipse.jdt.ls
5 participants
@gorkem @fbricon @guw @kittaakos @Yanpas