Add check for Edge browser setText issuing a location change url #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add check for URL starting with "data:" which occurs when setText is called on Edge browser and use handler.handleTextSet() - fixes: eclipse-jdt#248
ktatavarthi
pushed a commit
to ktatavarthi/eclipse.jdt.ui
that referenced
this pull request
Nov 4, 2022
…ipse-jdt#306) - add check for URL starting with "data:" which occurs when setText is called on Edge browser and use handler.handleTextSet() - fixes: eclipse-jdt#248
ktatavarthi
added a commit
that referenced
this pull request
Nov 4, 2022
* Add check for Edge browser setText issuing a location change url (#306) - add check for URL starting with "data:" which occurs when setText is called on Edge browser and use handler.handleTextSet() - fixes: #248 * Increase plugin version Signed-off-by: Kalyan Prasad Tatavarthi <[email protected]> Signed-off-by: Kalyan Prasad Tatavarthi <[email protected]> Co-authored-by: Jeff Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes issue caused by trying to interpret location change issued by MS Edge browser as a URL when setText is used in browser.
How to test
Use MS Edge browser in Eclipse using "-Dorg.eclipse.swt.browser.DefaultType=edge" and examine JDT tooltips as specified
in the original issue: #248
Author checklist