Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InferenceVariable#hashCode is overly time consuming #623

Open
RoiSoleil opened this issue Jan 3, 2023 · 2 comments
Open

InferenceVariable#hashCode is overly time consuming #623

RoiSoleil opened this issue Jan 3, 2023 · 2 comments
Labels
performance

Comments

@RoiSoleil
Copy link
Contributor

Eclipse: Version: 2022-12 (4.26.0), Build id: 20221201-1913

InferenceVariable#hashCode is overly time consuming in InferenceContext18

By caching hashCode value, my comilation time is reduced by 7%.
@RoiSoleil RoiSoleil mentioned this issue Jan 3, 2023
Closed
3 tasks
@iloveeclipse
Copy link
Member

Could you please provide example project or at least profiler snapshot before / after?

RoiSoleil added a commit to RoiSoleil/eclipse.jdt.core that referenced this issue Jan 4, 2023
@RoiSoleil
Avoid multiple computation of hashCode on InferenceVariable
eb81fab 
Fixes: eclipse-jdt#623
iloveeclipse pushed a commit to RoiSoleil/eclipse.jdt.core that referenced this issue Jan 9, 2023
@RoiSoleil @iloveeclipse
Avoid multiple computation of hashCode on InferenceVariable
dc6fe0b 
Fixes: eclipse-jdt#623
@jukzi
Copy link
Contributor

jukzi commented May 24, 2023

If hashCode() is really called that often to be performance relevant it might be more likely due to a hash collision. But without any example usecase / sampling it's impossible to investigate.

mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Jul 25, 2024
@testforstephen
Report "unused ..." diagnostics (eclipse-jdt#623)
4f8cf89 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Jul 26, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
f8fc7d4 
* Report diagnostics for the unused imports & private members & local variables
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this issue Jul 29, 2024
@testforstephen @akurtakov
Report "unused ..." diagnostics (eclipse-jdt#623)
85319ea 
* Report diagnostics for the unused imports & private members & local variables
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this issue Aug 16, 2024
@testforstephen @akurtakov
Report "unused ..." diagnostics (eclipse-jdt#623)
3f38435 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 5, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
395534c 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 9, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
8acafcf 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 10, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
8abaac2 
* Report diagnostics for the unused imports & private members & local variables
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this issue Sep 18, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
bc6a003 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 24, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
2e2e307 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Sep 24, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
5ed1fc5 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Oct 15, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
fcdf4c1 
* Report diagnostics for the unused imports & private members & local variables
datho7561 pushed a commit to datho7561/eclipse.jdt.core that referenced this issue Oct 18, 2024
@testforstephen @rgrunber
Report "unused ..." diagnostics (eclipse-jdt#623)
5043597 
* Report diagnostics for the unused imports & private members & local variables
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Oct 23, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
fcbf160 
* Report diagnostics for the unused imports & private members & local variables
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this issue Nov 12, 2024
@testforstephen @mickaelistria
Report "unused ..." diagnostics (eclipse-jdt#623)
2601619 
* Report diagnostics for the unused imports & private members & local variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid multiple computation of hashCode on InferenceVariable RoiSoleil/eclipse.jdt.core
3 participants
@iloveeclipse @RoiSoleil @jukzi