-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#390] event based comm example cpp #524
Merged
elfenpiff
merged 10 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-390-event-based-comm-example-cpp
Nov 27, 2024
Merged
[#390] event based comm example cpp #524
elfenpiff
merged 10 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-390-event-based-comm-example-cpp
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfenpiff
force-pushed
the
iox2-390-event-based-comm-example-cpp
branch
from
November 24, 2024 15:23
437ceef
to
15f2f35
Compare
elfenpiff
force-pushed
the
iox2-390-event-based-comm-example-cpp
branch
from
November 24, 2024 15:30
15f2f35
to
c766160
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 78.88% 78.82% -0.06%
==========================================
Files 201 201
Lines 24220 24220
==========================================
- Hits 19106 19092 -14
- Misses 5114 5128 +14 |
elBoberido
reviewed
Nov 25, 2024
elfenpiff
force-pushed
the
iox2-390-event-based-comm-example-cpp
branch
from
November 25, 2024 22:42
8c67b11
to
b2db0fd
Compare
orecham
reviewed
Nov 25, 2024
…stom{Publisher|Subscriber}
elBoberido
approved these changes
Nov 26, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Ports the rust event_based_communication example to C++.
Additionally, introduce
FileDescriptorBased
and implement it forFileDescriptorView
so thatWaitSet::attach_**()
can be handled easier and the user does not have to acquire low-level implementation details like the file descriptor.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #390