Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#430] Fix clippy single match warning in package iceoryx2 #431

Merged

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Oct 3, 2024

Notes for Reviewer

This change is done by calling cargo clippy --fix --lib -p iceoryx2
I'm still learning about the code of iceoryx2, so I tried to improve some of them(trivial but nice to have) during the process.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #430

…ryx2

* the change is done by running 'cargo clippy --fix --lib -p iceoryx2'
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 58.97436% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (6d25b61) to head (e6ba9cc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/port/publisher.rs 48.27% 15 Missing ⚠️
iceoryx2/src/port/notifier.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   78.93%   78.95%   +0.02%     
==========================================
  Files         195      195              
  Lines       22840    22836       -4     
==========================================
+ Hits        18029    18031       +2     
+ Misses       4811     4805       -6     
Files with missing lines Coverage Δ
iceoryx2/src/node/mod.rs 70.99% <ø> (ø)
iceoryx2/src/port/subscriber.rs 92.93% <100.00%> (-0.06%) ⬇️
iceoryx2/src/port/notifier.rs 90.05% <66.66%> (ø)
iceoryx2/src/port/publisher.rs 84.94% <48.27%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

@elBoberido elBoberido merged commit fe1fc38 into eclipse-iceoryx:main Oct 3, 2024
54 checks passed
@xieyuschen xieyuschen deleted the iox2-430-fix-clippy-error branch October 4, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants