Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#924 Add icedocker example readme #925

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Sep 15, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff
Copy link
Contributor Author

@r7vme Ping, could you please have a look at this PR?

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #925 (2b0aeaf) into master (8e2edeb) will increase coverage by 1.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   75.71%   77.52%   +1.80%     
==========================================
  Files         335      335              
  Lines       12222    12267      +45     
  Branches     2038     1831     -207     
==========================================
+ Hits         9254     9510     +256     
+ Misses       2178     2131      -47     
+ Partials      790      626     -164     
Flag Coverage Δ
unittests 76.42% <ø> (+1.78%) ⬆️
unittests_timing 30.35% <ø> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/cxx/helplets.cpp 63.63% <0.00%> (-6.37%) ⬇️
iceoryx_posh/source/roudi/service_registry.cpp 96.92% <0.00%> (-3.08%) ⬇️
...e/relocatable_pointer/base_relocatable_pointer.cpp 12.50% <0.00%> (-2.66%) ⬇️
iceoryx_hoofs/source/log/logging.cpp 100.00% <0.00%> (ø)
iceoryx_hoofs/source/log/logmanager.cpp 63.33% <0.00%> (ø)
iceoryx_hoofs/platform/linux/source/grp.cpp 100.00% <0.00%> (ø)
iceoryx_hoofs/platform/linux/source/file.cpp 100.00% <0.00%> (ø)
iceoryx_hoofs/platform/linux/source/mman.cpp 100.00% <0.00%> (ø)
iceoryx_posh/source/gateway/gateway_base.cpp 0.00% <0.00%> (ø)
iceoryx_hoofs/platform/linux/source/fnctl.cpp 100.00% <0.00%> (ø)
... and 58 more

r7vme
r7vme previously approved these changes Sep 15, 2021
Copy link

@r7vme r7vme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iceoryx_examples/icedocker/README.md Show resolved Hide resolved
iceoryx_examples/icedocker/README.md Show resolved Hide resolved
iceoryx_examples/icedocker/README.md Show resolved Hide resolved
elBoberido
elBoberido previously approved these changes Sep 16, 2021
README.md Outdated Show resolved Hide resolved
    - adjust iceoryx rust binding path
    - Add platform overview with supported features
    - Use unambiguous symbols in platform support matrix

Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
elBoberido previously approved these changes Sep 17, 2021
README.md Show resolved Hide resolved
iceoryx_examples/icedocker/README.md Outdated Show resolved Hide resolved
iceoryx_examples/icedocker/README.md Outdated Show resolved Hide resolved
iceoryx_examples/icedocker/README.md Outdated Show resolved Hide resolved
…check marks in readme

Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff merged commit 72a5cf7 into eclipse-iceoryx:master Sep 22, 2021
@elfenpiff elfenpiff deleted the iox-#924-docker-example branch September 22, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants