Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#415 Rename variable and test case name in ServiceRegistry_test and fix bug in ServiceDescription c'tor #917

Merged

Commits on Sep 1, 2021

  1. iox-eclipse-iceoryx#415 Address review findings from eclipse-iceoryx#860

     renaming test cases and member variable
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    0397cec View commit details
    Browse the repository at this point in the history
  2. iox-eclipse-iceoryx#415 Address review finding from eclipse-iceoryx#860

    … fixing ServiceDescription deserialisation
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    0af7817 View commit details
    Browse the repository at this point in the history
  3. iox-eclipse-iceoryx#415 Add additional unit test case for ServiceDesc…

    …ription
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9116bf4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. iox-eclipse-iceoryx#415 Adapt API of ServiceRegistry::remove()

    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    e6091ad View commit details
    Browse the repository at this point in the history
  2. iox-eclipse-iceoryx#415 Simplify serialization error handling

    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    56ebee1 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. iox-eclipse-iceoryx#415 Move deserialization of ServiceDescription in…

    …to static method
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    53b9fe5 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. iox-eclipse-iceoryx#415 Rename maybeService to deserializationResult …

    …and add hint in CONTRIBUTING.md
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1ccaf9e View commit details
    Browse the repository at this point in the history
  2. iox-eclipse-iceoryx#415 Check for the error in the cxx::expected in S…

    …erviceDescription tests
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3770f20 View commit details
    Browse the repository at this point in the history
  3. iox-eclipse-iceoryx#415 Refactor test case of ServiceDescription the …

    …functional way
    
    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ce36de9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3a5d4cb View commit details
    Browse the repository at this point in the history
  5. iox-eclipse-iceoryx#415 Explicit example

    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    7b81efd View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. iox-eclipse-iceoryx#415 Add deserialization example to changelog

    Signed-off-by: Simon Hoinkis <[email protected]>
    mossmaurice committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    2815364 View commit details
    Browse the repository at this point in the history