Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#903 timed{send,receive} supported in mac os #904

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Aug 13, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #904 (152dfbb) into master (2635e29) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   75.72%   75.71%   -0.01%     
==========================================
  Files         335      335              
  Lines       12222    12222              
  Branches     2038     2038              
==========================================
- Hits         9255     9254       -1     
  Misses       2178     2178              
- Partials      789      790       +1     
Flag Coverage Δ
unittests 74.63% <ø> (-0.01%) ⬇️
unittests_timing 29.58% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._hoofs/source/posix_wrapper/unix_domain_socket.cpp 62.38% <ø> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 79.41% <0.00%> (-5.89%) ⬇️
iceoryx_posh/source/roudi/process_manager.cpp 60.35% <0.00%> (+0.29%) ⬆️

Comment on lines +58 to +62
if (sentBytes <= 0 && timeout.tv_sec != 0 && timeout.tv_usec != 0)
{
sleepFor(timeout);
return sendto(sockfd, buf, len, flags, dest_addr, addrlen);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally you would sleep for e.g. 10ms in a loop, but this is also fine for now

@dkroenke dkroenke added the enhancement New feature label Aug 13, 2021
@dkroenke dkroenke self-requested a review August 13, 2021 13:31
@elfenpiff elfenpiff merged commit 8e2edeb into eclipse-iceoryx:master Aug 13, 2021
@elfenpiff elfenpiff deleted the iox-#903-implement-timing-functions-for-mac-os-sockets branch August 13, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement timed{send,receive} for MacOS
3 participants