-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #252 remove redundant methods from pubsub api #380
Merged
orecham
merged 3 commits into
eclipse-iceoryx:master
from
orecham:iox-#252-remove-redundant-methods-from-pubsub-api
Nov 20, 2020
Merged
Iox #252 remove redundant methods from pubsub api #380
orecham
merged 3 commits into
eclipse-iceoryx:master
from
orecham:iox-#252-remove-redundant-methods-from-pubsub-api
Nov 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscribers. Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham
requested review from
mossmaurice,
marthtz,
dkroenke,
budrus,
elfenpiff,
elBoberido and
MatthiasKillat
November 19, 2020 14:00
elBoberido
reviewed
Nov 19, 2020
elBoberido
previously approved these changes
Nov 19, 2020
13 tasks
budrus
previously approved these changes
Nov 20, 2020
13 tasks
elfenpiff
reviewed
Nov 20, 2020
@@ -51,7 +51,7 @@ class BasePublisher : public PublisherInterface<T> | |||
BasePublisher& operator=(const BasePublisher&) = delete; | |||
BasePublisher(BasePublisher&& rhs) = default; | |||
BasePublisher& operator=(BasePublisher&& rhs) = default; | |||
~BasePublisher(); | |||
virtual ~BasePublisher(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woh whoopsi we all overlooked that one. Good catch!
elfenpiff
reviewed
Nov 20, 2020
…sts. Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
elBoberido
approved these changes
Nov 20, 2020
budrus
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References