Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #252 remove redundant methods from pubsub api #380

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Nov 19, 2020

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

  • Closes TBD

…subscribers.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
elBoberido
elBoberido previously approved these changes Nov 19, 2020
@elBoberido elBoberido linked an issue Nov 19, 2020 that may be closed by this pull request
13 tasks
@elBoberido elBoberido removed a link to an issue Nov 19, 2020
13 tasks
budrus
budrus previously approved these changes Nov 20, 2020
@dkroenke dkroenke linked an issue Nov 20, 2020 that may be closed by this pull request
13 tasks
@@ -51,7 +51,7 @@ class BasePublisher : public PublisherInterface<T>
BasePublisher& operator=(const BasePublisher&) = delete;
BasePublisher(BasePublisher&& rhs) = default;
BasePublisher& operator=(BasePublisher&& rhs) = default;
~BasePublisher();
virtual ~BasePublisher();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woh whoopsi we all overlooked that one. Good catch!

@orecham orecham dismissed stale reviews from budrus and elBoberido via 1b9b901 November 20, 2020 09:35
@budrus budrus self-requested a review November 20, 2020 16:03
@orecham orecham merged commit ca3f818 into eclipse-iceoryx:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building blocks in iceoryx
4 participants